Skip to content

Commit

Permalink
Added deprecation TODO comments to bulk async skeleton GET endpoints.
Browse files Browse the repository at this point in the history
  • Loading branch information
kebwi committed Dec 16, 2024
1 parent 00a9301 commit d6230f1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions caveclient/endpoints.py
Original file line number Diff line number Diff line change
Expand Up @@ -320,11 +320,11 @@
+ "/{datastack_name}/bulk/get_skeletons/{output_format}/{gen_missing_sks}/{root_ids}",
"get_bulk_skeletons_via_skvn_rids": skeleton_v1
+ "/{datastack_name}/bulk/get_skeletons/{skeleton_version}/{output_format}/{gen_missing_sks}/{root_ids}",
# DEPRECATED: This endpoint is deprecated and will be removed in the future.
# TODO: DEPRECATED: This endpoint is deprecated and will be removed in the future.
# Please use the POST endpoint in the future.
"gen_bulk_skeletons_via_rids": skeleton_v1
+ "/{datastack_name}/bulk/gen_skeletons/{root_ids}",
# DEPRECATED: This endpoint is deprecated and will be removed in the future.
# TODO: DEPRECATED: This endpoint is deprecated and will be removed in the future.
# Please use the POST endpoint in the future.
"gen_bulk_skeletons_via_skvn_rids": skeleton_v1
+ "/{datastack_name}/bulk/gen_skeletons/{skeleton_version}/{root_ids}",
Expand Down
2 changes: 1 addition & 1 deletion caveclient/skeletonservice.py
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ def _build_bulk_async_endpoint(
endpoint_mapping = self.default_url_mapping
endpoint_mapping["datastack_name"] = datastack_name
if not post:

Check warning on line 310 in caveclient/skeletonservice.py

View check run for this annotation

Codecov / codecov/patch

caveclient/skeletonservice.py#L310

Added line #L310 was not covered by tests
# DEPRECATED: This endpoint is deprecated and will be removed in the future.
# TODO: DEPRECATED: This endpoint is deprecated and will be removed in the future.
# Please use the POST endpoint in the future.
endpoint_mapping["root_ids"] = ",".join([str(v) for v in root_ids])

Check warning on line 313 in caveclient/skeletonservice.py

View check run for this annotation

Codecov / codecov/patch

caveclient/skeletonservice.py#L313

Added line #L313 was not covered by tests

Expand Down

0 comments on commit d6230f1

Please sign in to comment.