Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

按 ctrl-enter 直接发帖 Fix #11 #41

Closed
wants to merge 2 commits into from

Conversation

zhzhzoo
Copy link
Contributor

@zhzhzoo zhzhzoo commented Jan 17, 2015

No description provided.

@huxuan
Copy link
Member

huxuan commented Jan 19, 2015

Hi @zhzhzoo, Thanks for you contribution!

I got following errror when use it for the first time and by press ctrl+Enter for the second time, it seems to work. Can you help me to confirm whether it works on your side?

And another question is that #11 is used for REPLY a thread not for new a thread. So I would suggest you remove the Fix #11 in your PR title.

snip20150119_14

@JeldorPKU
Copy link
Contributor

Nothing happens when I press Control-Return. It only starts a new line. I tested your work on Safari.

@huxuan
Copy link
Member

huxuan commented Jan 19, 2015

OK, then maybe the problem is about the title. This PR doesn't fix #11 completely. Please remove that trigger. But you can still make a reference to it.

@zhzhzoo zhzhzoo closed this Jan 19, 2015
@zhzhzoo
Copy link
Contributor Author

zhzhzoo commented Jan 19, 2015

啊 我错了。。。没有改掉回复界面应该把回复界面改掉~

@zhzhzoo zhzhzoo mentioned this pull request Jun 6, 2015
@huxuan huxuan reopened this Jun 9, 2015
@JeldorPKU
Copy link
Contributor

我们真的还要继续弄这个吗?还是直接去弄新的?

@huxuan
Copy link
Member

huxuan commented Jun 9, 2015

@JeldorPKU 代码修改没有啥冲突,应该没啥大问题。

@huxuan
Copy link
Member

huxuan commented Jun 9, 2015

@zhzhzoo 修改代码之前先rebase一下upstream/master吧,如果不确定git怎么用可以等当面一起搞一下。

@zhzhzoo
Copy link
Contributor Author

zhzhzoo commented Jun 14, 2015

@huxuan 好吧呀。。。也许是过了太长时间的缘故吧~~

@huxuan
Copy link
Member

huxuan commented Jun 15, 2015

经常rebase/merge是好习惯,一方面是为了提交pull request的时候减小冲突的可能性,另一方面本身代码如果和别的代码耦合比较大的话,在最新的代码里测试也是相对而言更靠谱的。

@huxuan
Copy link
Member

huxuan commented Jul 26, 2016

Close as no further response for a long time. Feel free to reopen it when ready.

@huxuan huxuan closed this Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants