-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
按 ctrl-enter 直接发帖 Fix #11 #41
Conversation
Hi @zhzhzoo, Thanks for you contribution! I got following errror when use it for the first time and by press ctrl+Enter for the second time, it seems to work. Can you help me to confirm whether it works on your side? And another question is that #11 is used for REPLY a thread not for new a thread. So I would suggest you remove the Fix #11 in your PR title. |
Nothing happens when I press Control-Return. It only starts a new line. I tested your work on Safari. |
OK, then maybe the problem is about the title. This PR doesn't fix #11 completely. Please remove that trigger. But you can still make a reference to it. |
啊 我错了。。。没有改掉回复界面应该把回复界面改掉~ |
我们真的还要继续弄这个吗?还是直接去弄新的? |
@JeldorPKU 代码修改没有啥冲突,应该没啥大问题。 |
@zhzhzoo 修改代码之前先 |
@huxuan 好吧呀。。。也许是过了太长时间的缘故吧~~ |
经常rebase/merge是好习惯,一方面是为了提交pull request的时候减小冲突的可能性,另一方面本身代码如果和别的代码耦合比较大的话,在最新的代码里测试也是相对而言更靠谱的。 |
Close as no further response for a long time. Feel free to reopen it when ready. |
No description provided.