This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update README file about services add warning about use servic value add `helm status` command output
fahchen
reviewed
Mar 8, 2024
fahchen
reviewed
Mar 8, 2024
necessary to properly render service ports and match them in ingress router
fahchen
reviewed
Mar 8, 2024
fahchen
reviewed
Mar 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
全部有兼容处理的地方都做一下 todo,另外版本那个可以先不做大版本升级,我们现在还兼容了之前的,还不算 break change,等我们把兼容代码去除掉之后,就可以做大版本升级了
所以 todo 里面的描述可以写成:1. 升级成什么,2. 在 2.0.0 后会被移除支持
fahchen
approved these changes
Mar 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appIngressroute
toappingressroutes
helm status
get access address