Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement abstract faotory example #35

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

MiJey
Copy link
Contributor

@MiJey MiJey commented Jan 28, 2022

CheckList

#2 Abstract factory에 대한 예제 코드를 추가하였습니다.

  • Documentation
  • Self reviewed

Done

@MiJey MiJey self-assigned this Feb 6, 2022
Copy link
Contributor

@muuty muuty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

실제로 테마별 구성요소 빌드에 abstract factory 패턴을 이용하네요(링크)
나중에 써먹을 수 있는 유용한 예제인 것 같습니다~ LGTM 👍


- 세트 아이템: 모자, 의상, 무기, 신발
- 갑옷 세트: 투구, 체인메일, 한손검, 부츠
- 광인의 천옷세트: 두건, 개량한복, 단소, 지압 슬리퍼
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예제 코드를 보고 싶은 예시네요 ㅋㅋ

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예제가 재미있네요 ㅋㅋ

Copy link
Contributor

@Taek-Gu Taek-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테마 예제 좋네요! 여러 파일을 사용하는 예제는 문서에 링킹이 잘 되있거나, 한 디렉터리에 묶어놓아야 할 것 같네요.

Copy link
Contributor

@gwolves gwolves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


- 세트 아이템: 모자, 의상, 무기, 신발
- 갑옷 세트: 투구, 체인메일, 한손검, 부츠
- 광인의 천옷세트: 두건, 개량한복, 단소, 지압 슬리퍼
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예제가 재미있네요 ㅋㅋ

@muuty muuty merged commit d2361ae into main Feb 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the abstract-factory-example-nike branch February 15, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants