Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

feat(BUX-358): remove redundant cron job #485

Closed

Conversation

arkadiuszos4chain
Copy link
Contributor

@arkadiuszos4chain arkadiuszos4chain commented Nov 29, 2023

  • remove check tx cron job
  • unify recordMonitoredTransaction and RecordRawTransaction
  • move and refactorize action_transaction.recordTxHex() => tx_service.saveRawTransaction()

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@arkadiuszos4chain arkadiuszos4chain self-assigned this Nov 29, 2023
@mergify mergify bot added the feature Any new significant addition label Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #485 (7a879c2) into rc-beef-v2-payments (b65bc68) will increase coverage by 0.19%.
The diff coverage is 8.19%.

❗ Current head 7a879c2 differs from pull request most recent head a6bc33d. Consider uploading reports for the commit a6bc33d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           rc-beef-v2-payments     #485      +/-   ##
=======================================================
+ Coverage                52.72%   52.91%   +0.19%     
=======================================================
  Files                      108      106       -2     
  Lines                    11318    11073     -245     
=======================================================
- Hits                      5967     5859     -108     
+ Misses                    4887     4750     -137     
  Partials                   464      464              
Flag Coverage Δ
unittests 52.91% <8.19%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client_options.go 74.17% <ø> (-0.06%) ⬇️
model_transaction_config.go 80.98% <ø> (ø)
sync_tx_service.go 20.48% <ø> (+0.18%) ⬆️
tasks.go 0.00% <ø> (ø)
model_incoming_transactions.go 55.27% <0.00%> (+0.82%) ⬆️
record_tx_strategy_external_incoming_tx.go 23.85% <0.00%> (ø)
action_transaction.go 35.24% <0.00%> (+10.46%) ⬆️
monitor_event_handler.go 0.00% <0.00%> (ø)
model_transactions.go 80.95% <55.55%> (+3.65%) ⬆️
tx_service.go 61.68% <0.00%> (-1.23%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b65bc68...a6bc33d. Read the comment docs.

@arkadiuszos4chain arkadiuszos4chain changed the base branch from master to rc-beef-v2-payments November 29, 2023 13:25
@arkadiuszos4chain arkadiuszos4chain force-pushed the feat-358-rmv-check-tx-job branch from 7a879c2 to a6bc33d Compare November 29, 2023 13:27
@arkadiuszos4chain arkadiuszos4chain deleted the feat-358-rmv-check-tx-job branch December 6, 2023 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants