Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

fix(BUX-250): record internal tx #469

Merged
merged 10 commits into from
Nov 15, 2023

Conversation

arkadiuszos4chain
Copy link
Contributor

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@arkadiuszos4chain arkadiuszos4chain self-assigned this Nov 14, 2023
@arkadiuszos4chain arkadiuszos4chain requested a review from a team as a code owner November 14, 2023 00:20
@mergify mergify bot added the bug-P3 Lowest rated bug, affects nearly none or low-impact label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #469 (5a222e2) into rc-beef-v1-payments (b59ead9) will increase coverage by 0.08%.
The diff coverage is 30.32%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           rc-beef-v1-payments     #469      +/-   ##
=======================================================
+ Coverage                52.50%   52.58%   +0.08%     
=======================================================
  Files                      106      106              
  Lines                    11153    11166      +13     
=======================================================
+ Hits                      5856     5872      +16     
+ Misses                    4828     4827       -1     
+ Partials                   469      467       -2     
Flag Coverage Δ
unittests 52.58% <30.32%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client_options.go 74.22% <100.00%> (-0.06%) ⬇️
locks.go 100.00% <ø> (ø)
model_sync_transactions.go 73.10% <50.00%> (+2.30%) ⬆️
record_tx.go 78.94% <95.23%> (+4.75%) ⬆️
action_transaction.go 27.56% <40.00%> (+0.20%) ⬆️
paymail_service_provider.go 0.00% <0.00%> (ø)
sync_tx_service.go 20.48% <14.28%> (+1.84%) ⬆️
tasks.go 0.00% <0.00%> (ø)
record_tx_strategy_outgoing_tx.go 54.54% <46.66%> (+0.81%) ⬆️
record_tx_strategy_external_incoming_tx.go 23.85% <20.51%> (-2.53%) ⬇️
... and 1 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b59ead9...5a222e2. Read the comment docs.

@arkadiuszos4chain arkadiuszos4chain merged commit a61d1aa into rc-beef-v1-payments Nov 15, 2023
@mergify mergify bot deleted the fix-250-record-internal-tx branch November 15, 2023 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug-P3 Lowest rated bug, affects nearly none or low-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants