Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

feat(BUX-168): beefTx for not mined inputs #468

Merged
merged 12 commits into from
Nov 24, 2023

Conversation

wregulski
Copy link
Contributor

@wregulski wregulski commented Nov 10, 2023

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@wregulski wregulski requested a review from a team as a code owner November 10, 2023 15:14
@wregulski wregulski changed the title ] [DRAFT] feat(BUX-168): beefTx for not mined inputs Nov 10, 2023
@mergify mergify bot added the feature Any new significant addition label Nov 10, 2023
@wregulski wregulski requested review from a team and sirdeggen November 10, 2023 15:14
@wregulski wregulski marked this pull request as draft November 10, 2023 15:14
@wregulski wregulski changed the base branch from master to tests-DO-NOT-MERGE-250-beef-rc-2 November 10, 2023 15:20
@wregulski wregulski force-pushed the feat/168-parent-inputs-beef branch from baeecdc to f25af48 Compare November 21, 2023 13:03
@wregulski wregulski changed the base branch from tests-DO-NOT-MERGE-250-beef-rc-2 to master November 23, 2023 07:59
beef_bump.go Show resolved Hide resolved
Copy link
Contributor

@pawellewandowski98 pawellewandowski98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything works

model_draft_transactions.go Show resolved Hide resolved
beef_tx.go Outdated Show resolved Hide resolved
beef_bump.go Outdated Show resolved Hide resolved
beef_bump.go Outdated Show resolved Hide resolved
beef_tx_mock.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #468 (9a7b689) into rc-beef-v2-payments (e8fe1ad) will increase coverage by 0.84%.
The diff coverage is 67.33%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           rc-beef-v2-payments     #468      +/-   ##
=======================================================
+ Coverage                52.58%   53.43%   +0.84%     
=======================================================
  Files                      106      108       +2     
  Lines                    11166    11281     +115     
=======================================================
+ Hits                      5872     6028     +156     
+ Misses                    4827     4779      -48     
- Partials                   467      474       +7     
Flag Coverage Ξ”
unittests 53.43% <67.33%> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
beef_tx_mock.go 100.00% <100.00%> (ΓΈ)
model_bump.go 68.99% <ΓΈ> (-0.44%) ⬇️
model_transactions.go 77.89% <ΓΈ> (ΓΈ)
paymail.go 55.79% <75.00%> (-0.55%) ⬇️
model_draft_transactions.go 73.24% <71.42%> (+0.62%) ⬆️
beef_tx.go 46.00% <66.66%> (+25.22%) ⬆️
beef_bump.go 78.33% <78.33%> (ΓΈ)
action_transaction.go 24.77% <0.00%> (-2.79%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update e8fe1ad...9a7b689. Read the comment docs.

@wregulski wregulski changed the title [DRAFT] feat(BUX-168): beefTx for not mined inputs feat(BUX-168): beefTx for not mined inputs Nov 23, 2023
@wregulski wregulski marked this pull request as ready for review November 23, 2023 13:04
@arkadiuszos4chain arkadiuszos4chain self-requested a review November 23, 2023 13:05
@wregulski wregulski changed the base branch from master to rc-beef-v2-payments November 23, 2023 13:06
beef_bump.go Show resolved Hide resolved
action_transaction.go Show resolved Hide resolved
@wregulski wregulski force-pushed the feat/168-parent-inputs-beef branch from 1e4db1b to aa79e40 Compare November 24, 2023 08:22
@wregulski wregulski merged commit 4b91c0f into rc-beef-v2-payments Nov 24, 2023
5 checks passed
@mergify mergify bot deleted the feat/168-parent-inputs-beef branch November 24, 2023 08:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants