-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 디자인 시스템 색상 및 폰트 적용 #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
confidential-nt
approved these changes
Dec 14, 2024
s2oy
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Jeong-jj
requested changes
Dec 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이전 #39 merging 부분과 특별히 conflict 날 부분은 없을 것으로 보이는데
혹시나 refactoring과정에서 파일 row 개수가 줄어든 경우가 있을 수도 있으니 한번 더 체크 후 re-push 부탁드리겠습니다!
…to feature/design-system
Jeong-jj
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
무엇을 위한 PR인가요?
변경사항 및 이유
이유: 새로운 디자인 시스템 가이드라인에 맞춰서 색상 체계 및 폰트 적용이 필요
작업 내역
tailwind 설정 변경
컴포넌트 스타일 수정
PR 특이 사항
![image](https://private-user-images.githubusercontent.com/70426440/395765274-1bb32afe-5ba6-431e-9cde-52618451615f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MTEwMTMsIm5iZiI6MTczOTYxMDcxMywicGF0aCI6Ii83MDQyNjQ0MC8zOTU3NjUyNzQtMWJiMzJhZmUtNWJhNi00MzFlLTljZGUtNTI2MTg0NTE2MTVmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA5MTE1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY5NDRjNWU1NmE4YWI3ODQ3M2FhMThkNjY0YzU5YjExZjczYzY4MTUxZmU1NTlmOWYxOWRkODE5YzMyMThhZjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.WuN1ZMrw-koNrqVx66wHq90osLGjD6bthhaUuqU_b0c)
새로운 색상 시스템에 gray색상이 많아서 gray-{sale} 으로 변경했습니다.
기존에 border-gray-500 과 같이 하드코딩한 색상이 config에 설정된 색상을 수정돼서 스타일이 꺠질 가능성이 있습니다.
스크린샷
Issue Number
close: #
어떤 부분에 리뷰어가 집중하면 좋을까요?
피그마에 적용된 배경색을 제대로 줬는지 잘 모르겠네요.