Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for deno 1.6 and std v0.83.0 #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cromatikap
Copy link

Hi!

I was reading your awesome article "Create your first module with Deno" and I realized that Deno.test() should be used now.

I hope this PR is helpful, any feedback would be appreciated.

Copy link
Owner

@BrunnerLivio BrunnerLivio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Thanks, left you some comments

@@ -6,7 +6,7 @@ jobs:

strategy:
matrix:
deno: [0.32.0, 0.31.0, 0.30.0]
deno: ["v0.83.0"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an error in the pipeline. Is it maybe because of the "?

Error: Error: Unexpected HTTP response: 404
    at /home/runner/work/_actions/denolib/setup-deno/master/dist/index.js:3366:25
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/denolib/setup-deno/master/dist/index.js:3271:58)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
Suggested change
deno: ["v0.83.0"]
deno: [0.83.0]

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I had the same 404 error using [0.83.0], then I went on denolib/setup-deno repository mentioned in the article and the readme shows deno: ["v1.0.0", "v0.42.0", "v1.x", "v0.x", "nightly"].
I don't really know what to do now.

test_deps.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants