Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dist] Make dvr-scan installable via pyproject.toml. #205

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

frafra
Copy link

@frafra frafra commented Feb 28, 2025

Migrate from the deprecated setup.py to pyproject.toml.

I did the migration using hatch, via uv tool run hatch new --init and did some minor adjustments.

It would be also possible to add optional dependencies, like opencv with pillow, but it is not possible to run dvr-scan without them, so I just made them mandatory, to reflect the current status of the software.

The tool can now be installed from git like using uv/uvx, like this:

uvx git+https://github.com/frafra/DVR-Scan.git@pyproject-toml

@frafra frafra marked this pull request as draft February 28, 2025 22:28
@frafra
Copy link
Author

frafra commented Feb 28, 2025

I updated the Dockerfile, so that it builds from the source code, using uv, with caching, multi-staging etc.

I set the PR as draft, since I notice that not all the code is installed when building the container, and the dynamic versioning needs to be configured in pyproject.toml.

I also noticed that the dvr-scan-app entrypoint was not defined.

@Breakthrough
Copy link
Owner

Thanks for doing this, it's been on my radar for some time but I haven't gotten around to it yet.

I also noticed that the dvr-scan-app entrypoint was not defined.

Indeed, that's only in the develop and releases/1.7 branch right now. Would it be alright if we target this PR until after v1.7 is released? I plan on doing that this weekend so you should not have to wait long.

@frafra
Copy link
Author

frafra commented Mar 1, 2025

Would it be alright if we target this PR until after v1.7 is released? I plan on doing that this weekend so you should not have to wait long.

I have no hurry, and the PR is not even complete, so that is totally fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants