Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic thumbnail generation based on highest scoring frame #169

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

goatzillax
Copy link
Contributor

This is a very basic cut of this functionality and doesn't comprehend certain options like comp_file. But it can still be quite useful as is.

fixes #159

…vent.

This is a very basic cut of this functionality and doesn't comprehend certain
options like comp_file.  But it can still be quite useful as is.

fixes Breakthrough#159
@Breakthrough Breakthrough added this to the v1.7 milestone Jul 10, 2024
@Breakthrough Breakthrough self-requested a review July 10, 2024 03:41
@Breakthrough
Copy link
Owner

Thanks for this, it looks like some unit tests are failing. Could you fix up the tests?

Copy link
Owner

@Breakthrough Breakthrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Breakthrough Breakthrough merged commit 386208c into Breakthrough:develop Jul 15, 2024
28 checks passed
@Breakthrough Breakthrough modified the milestones: v1.7, v1.6.2 Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants