Fix: check_order_number function on empty files #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When empty board is used, pcbnew.GetBoard().GetFileName() returns FileNotFound exception which was not handled in check_order_number function. Signed-off-by: Andrej Valek <[email protected]>
andy9a9
force-pushed
the
fix/file_not_found
branch
from
f32bd69 to
709309a
Compare
|
Good catch. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When empty board is used,
pcbnew.GetBoard().GetFileName()returnsFileNotFoundexception which was not handled incheck_order_numberfunction. CatchOSErrorexception which should fix this behaviour.Maybe longing an error would be useful?