Fix auth net request nil pointer (#245)

Description: fixed an nil pointer panics in auth net request builder TestPlan: unit tests
BoltApp · Oct 19, 2022 · ff18214 · ff18214
1 parent ac34c99
commit ff18214
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 11 deletions.
diff --git a/gateways/authorizenet/request_builders.go b/gateways/authorizenet/request_builders.go
@@ -44,21 +44,28 @@ func buildAuthRequest(merchantName string, transactionKey string, authRequest *s
 				CreditCard: creditCard,
 			},
 			BillingAddress: &BillingAddress{
-				FirstName:   authRequest.CreditCard.FirstName,
-				LastName:    authRequest.CreditCard.LastName,
-				Address:     billingAddress.StreetAddress1,
-				City:        billingAddress.Locality,
-				State:       billingAddress.RegionCode,
-				Zip:         billingAddress.PostalCode,
-				Country:     billingAddress.CountryCode,
-				PhoneNumber: billingAddress.PhoneNumber,
-			},
-			Customer: &Customer{
-				Email: common.SafeStr(billingAddress.Email),
+				FirstName: authRequest.CreditCard.FirstName,
+				LastName:  authRequest.CreditCard.LastName,
 			},
 		},
 	}
 
+	if billingAddress != nil {
+		authorizeRequest.TransactionRequest.BillingAddress = &BillingAddress{
+			FirstName:   authRequest.CreditCard.FirstName,
+			LastName:    authRequest.CreditCard.LastName,
+			Address:     billingAddress.StreetAddress1,
+			City:        billingAddress.Locality,
+			State:       billingAddress.RegionCode,
+			Zip:         billingAddress.PostalCode,
+			Country:     billingAddress.CountryCode,
+			PhoneNumber: billingAddress.PhoneNumber,
+		}
+		authorizeRequest.TransactionRequest.Customer = &Customer{
+			Email: common.SafeStr(billingAddress.Email),
+		}
+	}
+
 	if authRequest.MerchantOrderReference != "" {
 		invoiceNumber := sleet.TruncateString(authRequest.MerchantOrderReference, InvoiceNumberMaxLength)
 		authorizeRequest.TransactionRequest.Order = &Order{InvoiceNumber: invoiceNumber}

diff --git a/gateways/authorizenet/request_builders_test.go b/gateways/authorizenet/request_builders_test.go
@@ -264,6 +264,39 @@ func TestBuildAuthRequest(t *testing.T) {
 				},
 			},
 		},
+		{
+			"Basic Auth Request with nil Billing Address",
+			&sleet.AuthorizationRequest{
+				Amount:                     base.Amount,
+				CreditCard:                 base.CreditCard,
+				ClientTransactionReference: base.ClientTransactionReference,
+				ShopperReference:           "test",
+				MerchantOrderReference:     base.MerchantOrderReference,
+			},
+			&Request{
+				CreateTransactionRequest: CreateTransactionRequest{
+					MerchantAuthentication: MerchantAuthentication{Name: "MerchantName", TransactionKey: "Key"},
+					TransactionRequest: TransactionRequest{
+						TransactionType: TransactionTypeAuthOnly,
+						Amount:          &amount,
+						Payment: &Payment{
+							CreditCard: CreditCard{
+								CardNumber:     "4111111111111111",
+								ExpirationDate: "2023-10",
+								CardCode:       base.CreditCard.CVV,
+							},
+						},
+						BillingAddress: &BillingAddress{
+							FirstName: "Bolt",
+							LastName:  "Checkout",
+						},
+						Order: &Order{
+							InvoiceNumber: base.MerchantOrderReference[:InvoiceNumberMaxLength],
+						},
+					},
+				},
+			},
+		},
 	}
 
 	for _, c := range cases {