Skip to content

Commit

Permalink
multi target build does not build on master-15 (DynamoDS#15890)
Browse files Browse the repository at this point in the history
  • Loading branch information
mjkkirschner authored Mar 4, 2025
1 parent 1a071b4 commit 52bf6a7
Showing 1 changed file with 27 additions and 23 deletions.
50 changes: 27 additions & 23 deletions src/NodeServices/DynamoServices.csproj
Original file line number Diff line number Diff line change
@@ -1,24 +1,28 @@
<Project Sdk="Microsoft.NET.Sdk">
<ImportGroup Label="PropertySheets">
<Import Project="$(SolutionDir)Config\CS_SDK.props" />
</ImportGroup>
<PropertyGroup>
<ProductVersion>8.0.30703</ProductVersion>
<SchemaVersion>2.0</SchemaVersion>
<ProjectGuid>{EF879A10-041D-4C68-83E7-3192685F1BAE}</ProjectGuid>
<OutputType>Library</OutputType>
<AppDesignerFolder>Properties</AppDesignerFolder>
<RootNamespace>DynamoServices</RootNamespace>
<AssemblyName>DynamoServices</AssemblyName>
<DocumentationFile>$(OutputPath)\DynamoServices.XML</DocumentationFile>
<TargetFrameworks>netstandard2.0;net8.0;</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net8.0</TargetFrameworks>
</PropertyGroup>
<PropertyGroup>
<NoWarn>MSB3539;CS1591;NUnit2005;NUnit2007;CS0618;CS0612;CS0672</NoWarn>
</PropertyGroup>
<ItemGroup>
<!--exclude these dependencies as Sys.Ref.MetadataLoadContext.dll is already pulled in from other projects and the transitive deps are part of the .net8 runtime.-->
<PackageReference Include="System.Reflection.MetadataLoadContext" Version="8.0.0" ExcludeAssets="runtime" />
</ItemGroup>
<Project Sdk="Microsoft.NET.Sdk">
<ImportGroup Label="PropertySheets">
<Import Project="$(SolutionDir)Config\CS_SDK.props" />
</ImportGroup>
<PropertyGroup>
<ProductVersion>8.0.30703</ProductVersion>
<SchemaVersion>2.0</SchemaVersion>
<ProjectGuid>{EF879A10-041D-4C68-83E7-3192685F1BAE}</ProjectGuid>
<OutputType>Library</OutputType>
<AppDesignerFolder>Properties</AppDesignerFolder>
<RootNamespace>DynamoServices</RootNamespace>
<AssemblyName>DynamoServices</AssemblyName>
<DocumentationFile>$(OutputPath)\DynamoServices.XML</DocumentationFile>
<!--seems like an msbuild build bug - if both targetframework and
targetframeworks are set targetframeworks is ignored
even though it should take precedence according to the docs.
Dotnet build and builds in vs seem to work fine without this hack.-->
<TargetFramework>$(Undefined)</TargetFramework>
<TargetFrameworks>netstandard2.0;net8.0;</TargetFrameworks>
</PropertyGroup>
<PropertyGroup>
<NoWarn>MSB3539;CS1591;NUnit2005;NUnit2007;CS0618;CS0612;CS0672</NoWarn>
</PropertyGroup>
<ItemGroup>
<!--exclude these dependencies as Sys.Ref.MetadataLoadContext.dll is already pulled in from other projects and the transitive deps are part of the .net8 runtime.-->
<PackageReference Include="System.Reflection.MetadataLoadContext" Version="8.0.0" ExcludeAssets="runtime" />
</ItemGroup>
</Project>

0 comments on commit 52bf6a7

Please sign in to comment.