Skip to content

Commit

Permalink
clean up
Browse files Browse the repository at this point in the history
  • Loading branch information
QilongTang committed Feb 28, 2025
1 parent e8f8057 commit 46f2215
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/DynamoCore/Scheduler/UpdateGraphAsyncTask.cs
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ private static IEnumerable<NodeModel> ComputeModifiedNodes(WorkspaceModel worksp
///
private static void GetDownstreamNodes(NodeModel node, ICollection<NodeModel> gathered)
{
if (gathered.Contains(node) || node.IsFrozen) // Considered this node before, bail.pu
if (gathered.Contains(node) || node.IsFrozen || node.IsTransient) // Considered this node before, bail.pu
return;

gathered.Add(node);
Expand Down
4 changes: 2 additions & 2 deletions src/DynamoCoreWpf/Views/Core/NodeView.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@
</Grid>
<!-- Node preview state indication, light sparkle -->
<Grid x:Name="ClusterPreviewGlyph"
Visibility="{Binding Path=IsPreview, Converter={StaticResource BooleanToVisibilityCollapsedConverter}, Mode=OneWay}">
Visibility="{Binding Path=IsTransient, Converter={StaticResource BooleanToVisibilityCollapsedConverter}, Mode=OneWay}">
<Image x:Name="PreviewImage"
Width="16px"
Height="16px"
Expand Down Expand Up @@ -642,7 +642,7 @@
AncestorType={x:Type controls:WorkspaceView}},
Converter={StaticResource ZoomToOpacityConverter}}"
Style="{Binding Path=DataContext.StopNodeViewOpacityAnimations, RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type controls:WorkspaceView}}, Converter={StaticResource SZoomFadeOutPreview}}"
Visibility="{Binding Path=IsPreview, Converter={StaticResource BooleanToVisibilityCollapsedConverter}, Mode=OneWay, UpdateSourceTrigger=PropertyChanged}" />
Visibility="{Binding Path=IsTransient, Converter={StaticResource BooleanToVisibilityCollapsedConverter}, Mode=OneWay, UpdateSourceTrigger=PropertyChanged}" />

<!-- Displays when the node is Frozen/Warning/Error state and Zoom is below 0.4 -->
<Border Name="nodeColorOverlayZoomOut"
Expand Down
4 changes: 2 additions & 2 deletions src/DynamoManipulation/DynamoManipulationExtension.cs
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,8 @@ private bool TryCreateManipulator(NodeModel node)
node.PropertyChanged += OnNodePropertyChanged;
}

//No manipulator for frozen node or node in state of error
if (node.IsFrozen || node.IsInErrorState) return false;
//No manipulator for frozen node or node in state of error/ transient.
if (node.IsFrozen || node.IsInErrorState || node.IsTransient) return false;

//If the node already has a manipulator, then skip creating new one.
if (manipulatorDaemon.HasNodeManipulator(node)) return false;
Expand Down

0 comments on commit 46f2215

Please sign in to comment.