Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(megalinter): add github action #218

Merged
merged 7 commits into from
Jan 21, 2025
Merged

ci(megalinter): add github action #218

merged 7 commits into from
Jan 21, 2025

Conversation

Kashugoyal
Copy link
Contributor

@Kashugoyal Kashugoyal commented Nov 17, 2024 •
edited
Loading

PR for issue #188

Changes:

  1. Added megalinter github action
    1. Added .mega-linter.yml in the root directory for mega linter configuration
      1. No specific flavor chosen for the mega linter as the project contains files of all formats. We can potentially update this in the future.
      2. Disabled certain linters due to duplication and or redundancy.
      3. Disabled errors for spell checker (will spit out warnings)
      4. Disabled copypaste checker (JSCPD), can be added in a separate PR as this will need test refactor
    2. Updated contributing doc
  2. Linted code
    1. Updated repo wide yaml files to confirm to linter expectations
    2. Update Dockerfile
    3. Fixed broken links in markdown files
  3. Updated .gitignore

@Kashugoyal Kashugoyal marked this pull request as draft November 17, 2024 17:37
@Kashugoyal Kashugoyal mentioned this pull request Nov 17, 2024
Closed
@Kashugoyal Kashugoyal marked this pull request as ready for review November 18, 2024 01:50
ccoVeille
ccoVeille reviewed Nov 18, 2024
View reviewed changes
.mega-linter.yml Outdated Show resolved Hide resolved
.mega-linter.yml Outdated Show resolved Hide resolved
index.md Outdated Show resolved Hide resolved
@kehoecj kehoecj added OSS Community Contribution Contributions from the OSS Community pr-action-requested PR is awaiting feedback from the submitting developer labels Dec 3, 2024
@kehoecj
Copy link
Collaborator

kehoecj commented Jan 20, 2025

@Kashugoyal Please resolve conflicts and respond to questions in the review. Thanks!

@Kashugoyal Kashugoyal force-pushed the megalint-github-action branch from 8062cc7 to 8fde380 Compare January 21, 2025 01:22
@Kashugoyal
Copy link
Contributor Author

@Kashugoyal Please resolve conflicts and respond to questions in the review. Thanks!

The PR is ready.

@Kashugoyal Kashugoyal requested a review from kehoecj January 21, 2025 01:45
@Kashugoyal Kashugoyal force-pushed the megalint-github-action branch from c409f0f to 2e45896 Compare January 21, 2025 01:52
ccoVeille
ccoVeille approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kehoecj kehoecj added waiting-on-maintainer-review PR is waiting to be reviewed and functionally tested by the maintainers and removed pr-action-requested PR is awaiting feedback from the submitting developer labels Jan 21, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2025
View reviewed changes
.github/workflows/mega-linter.yml Fixed Show fixed Hide fixed
.github/workflows/mega-linter.yml Fixed Show resolved Hide resolved
.github/workflows/mega-linter.yml Fixed Show resolved Hide resolved
Dockerfile Fixed Show resolved Hide resolved
kehoecj
kehoecj requested changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@kehoecj kehoecj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kashugoyal Looks good! A couple findings from the scorecard workflow that should be easy to fix

@kehoecj kehoecj added pr-action-requested PR is awaiting feedback from the submitting developer and removed waiting-on-maintainer-review PR is waiting to be reviewed and functionally tested by the maintainers labels Jan 21, 2025
kehoecj
kehoecj approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@kehoecj kehoecj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @Kashugoyal for the PR!

@kehoecj kehoecj merged commit f4c0ee9 into Boeing:main Jan 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kehoecj kehoecj kehoecj approved these changes

@ccoVeille ccoVeille ccoVeille approved these changes

Assignees
No one assigned
Labels
OSS Community Contribution Contributions from the OSS Community pr-action-requested PR is awaiting feedback from the submitting developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kashugoyal @kehoecj @ccoVeille