-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the fsfinder to use concurrency #61
Comments
I can pick this up! @kehoecj |
It's yours! |
@AshwinKul28 Are you still interested in working on this issue? |
@kehoecj, can I take this ? |
Absolutely! I assigned it to you |
@kehoecj is there any specific dataset of config files that I could benchmark against? |
No, we don't have a current dataset to benchmark against. It would be less about a dataset and more about a large tree of subdirectories, for instance running the validator against |
@Axecalever Did you still want to work this issue? |
Hello. What do you think about using an external module like https://github.com/iafan/cwalk |
@nikonhub You're welcome to put up a draft MR with the implementation |
The current implementation of the file system finder is suitable for most use-cases but can get slow when recursing through a very large directory tree. It would improve performance to update the fsfinder to launch a new goroutine for each subdirectory. Determine a benchmark and determine if the worker pool needs to be limited to maximize performance as well as measuring the performance increase using goroutines
The text was updated successfully, but these errors were encountered: