Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rc/v0.0.6 #9

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Rc/v0.0.6 #9

merged 5 commits into from
Sep 4, 2024

Conversation

ml-ebs-ext
Copy link
Contributor

Fixes #7. Fixes #8.

@ml-ebs-ext ml-ebs-ext requested a review from a team as a code owner September 3, 2024 14:27
@ml-ebs-ext
Copy link
Contributor Author

The lineplot bug is fixed by avoiding a shiny::req inside the label_if_valid parameter of it_relabel_button. That code runs inside an observe and that triggers the gratuitous error reported by our esteemed power user.

I think the correlation heatmap fix is easily understood looking at the NEWS.md file and reading the code, but contact me if you need clarification.

mattkorb
mattkorb previously approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@mattkorb mattkorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ml-ebs-ext One small suggestion, but besides that it looks good.

R/mod_corr_hm.R Outdated Show resolved Hide resolved
@ml-ebs-ext @mattkorb
Grammar tweak
7ffbd7c 
Co-authored-by: Korbinian Matthias <[email protected]>
@ml-ebs-ext ml-ebs-ext merged commit 1925694 into main Sep 4, 2024
7 checks passed
@zsigmas zsigmas deleted the rc/v0.0.6 branch September 18, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkorb mattkorb mattkorb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ml-ebs-ext @mattkorb