Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rc/v0.1.0 #34

Merged
merged 63 commits into from
Dec 3, 2024
Merged

Rc/v0.1.0 #34

merged 63 commits into from
Dec 3, 2024

Conversation

ml-ebs-ext
Copy link
Contributor

@ml-ebs-ext ml-ebs-ext commented Dec 3, 2024 •
edited by zsigmas
Loading

Critical checks

  • Is the version number correct?

    • DESCRIPTION file

    • NEWS.md

  • Does the build pass?

Documentation

Does it include the following sections?

  • Module introduction with features

    • (O) Screenshots

  • Installation details

  • Explanation of function arguments

  • Data specifications and requirements

  • Different possible visualizations

  • Are the changes/new features included in NEWS.md?

  • (O) Screenshots

  • (O) Explanation of input menus

  • (O) Short articles on building the app, compatibility with other modules, known bugs,...

QC Report

  • Does it include a QC Report?

API conventions

  • Follows API convention

@ml-ebs-ext
mod_corr_hm spec and reshape for earliest error feedback.
35b6425
@ml-ebs-ext
Merge branch 'main' into earliest_error_feedback
b314bf6
@ml-ebs-ext
Stupid styler.
a457e38
@ml-ebs-ext
Move module check into a wrapper function.
7d8fa2c
@ml-ebs-ext
Styling.
1b9f883
@ml-ebs-ext
Empty API check generator.
8c25931
@ml-ebs-ext
Partial automatic API checking.
eb2ed0e
@ml-ebs-ext
Styler has opinions about whitespace.
2f94832
@ml-ebs-ext
Move API specs next to the modules they document.
6885280
@ml-ebs-ext
Remove overly user-friendly default.
4f1bb24
@ml-ebs-ext
More automatic API checking.
b562ddd
@ml-ebs-ext
Still hate the styler.
e1e4ffb
@ml-ebs-ext
Add manual checks to mod_corr_hm.
9e0a93f
@ml-ebs-ext
stylint
d3afcfa
@ml-ebs-ext
Route checker function through C_module.
ae4fa05
@ml-ebs-ext
Use filtered dataset on corr hm and adapt two mocks.
1687d21
@ml-ebs-ext
Remove dispatchers from mod_forest.
6a726b5
@ml-ebs-ext
Basic earliest error detection for forest plot. Some progress on line…
fe613ad 
… plot.
@ml-ebs-ext
Temporarily patch dv.manager remotes commit hash to get github action…
79a7b93 
…s working again.
@ml-ebs-ext
Better argument checks for mod devs and app creators.
7be8ac4
@ml-ebs-ext
Basic earliest error detection for box plot.
945e363
@ml-ebs-ext
Clean lintr noise.
a98eb75
@ml-ebs-ext
Prevent lintr cleanup from polluting history.
ccef71b
@ml-ebs-ext
Drop mod_roc dispatcher support.
21b62e8
@ml-ebs-ext
Tweaks and typos.
efc0a81
@ml-ebs-ext
Check that subjid vars are unique on all vars tagged as datasets.
e7fc77c
@ml-ebs-ext
Extract subj+cat+par+vis unique check.
6151786
@ml-ebs-ext
Basic earliest error detection for roc module.
fe4e099
@ml-ebs-ext
Drop mod_scatterplot dispatcher support.
7a1a623
@ml-ebs-ext
Basic earliest error detection for the scatterplot module.
2eef461
ml-ebs-ext and others added 24 commits November 27, 2024 09:36
@ml-ebs-ext
Basic mod_lineplot API spec.
e096bf7
@ml-ebs-ext
Merge branch 'dev' into earliest_error_feedback
2dbd466
@ml-ebs-ext
Force order of dependencies to allow lineplot shinyWidgets::pickerInp…
28d4517 
…ut visit selector to work.
@ml-ebs-ext
Merge branch 'main' into earliest_error_feedback
f805f9c
@ml-ebs-ext
Fuller mod_lineplot API spec.
721af70
@ml-ebs-ext
Dressing room column descriptors and check for uniqueness of PARAM ov…
e0a8eda 
…er all PARCATS.
@ml-ebs-ext
Patch papo message checker to use new afm[["data"]] field.
f56d4aa
@ml-ebs-ext
Update wfphm snap.
a12dd21
@ml-ebs-ext
Exposed datasets used by module.
06ffb5b
@ml-ebs-ext
Rename *_function API parameters as *_fn for consistency across the p…
f0108ba 
…ackage.
@ml-ebs-ext
Update lineplot test to cope with recent change.
a9ec6ba
@ml-ebs-ext
Fix (through a shameless hack) inconsistencies in wfphm graphical out…
cb58b42 
…put test.
@ml-ebs-ext
Include new wfphm snaps generated by the updated tests.
ae008b9
@ml-ebs-ext
Include new wfphm snaps generated by the updated tests (2).
a90f5a4
@ml-ebs-ext
Tweak man section name.
d28ff83
@ml-ebs-ext
Rename man section.
3ea2a8f
@ml-ebs-ext
Isolate checked module utilities into single object to reduce package…
51e9382 
… namespace pollution.
@ml-ebs-ext
Namespace a couple of symbols.
defac58
@ml-ebs-ext
Isolate type check utilities into single object to reduce package nam…
688e6fe 
…espace pollution.
@ml-ebs-ext
Isolate dressing room into single object to reduce package namespace …
30c5638 
…pollution.
@ml-ebs-ext
Expand DR afmm members.
8b5fc81
@ml-ebs-ext
Small CM tweak.
df3fe85
@ml-ebs-ext
Improved app creator messaging for blank visit values on lineplot.
d52f115
@ml-ebs-ext
Merge pull request #33 from Boehringer-Ingelheim/earliest_error_feedback
60b5cb6 
Earliest error feedback for all modules; provide used datasets to dv.manager; wfphm test fix; app creator error on lineplot blank visit
@ml-ebs-ext ml-ebs-ext requested a review from zsigmas December 3, 2024 09:42
@ml-ebs-ext ml-ebs-ext requested a review from a team as a code owner December 3, 2024 09:42
@ml-ebs-ext
Copy link
Contributor Author

If there is an error related to not passing styler it's because of an outdated rule that should apply no longer.

@ml-ebs-ext ml-ebs-ext merged commit 347329e into main Dec 3, 2024
18 checks passed
@ml-ebs-ext ml-ebs-ext deleted the rc/v0.1.0 branch December 10, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsigmas zsigmas zsigmas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ml-ebs-ext @zsigmas