Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add windows to test job matrix #63

Closed
wants to merge 6 commits into from
Closed

ci: add windows to test job matrix #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d58efab
ci: add windows to test job matrix
BobbieGoede Jan 24, 2025
37d3b5a
ci: include `matrix.os` in test job name
BobbieGoede Jan 24, 2025
9fd2bc8
test: temporarily run only ssg e2e tests
BobbieGoede Jan 24, 2025
b4a0766
test: resolve test path for windows compatibility
BobbieGoede Jan 24, 2025
3cc2e25
test: use `pnpx` instead of `npx`
BobbieGoede Jan 24, 2025
5f9f6df
test: revert running only ssg e2e tests
BobbieGoede Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@ jobs:
strategy:
matrix:
node-version: [18]
os: [ubuntu-latest]
os: [ubuntu-latest, windows-latest]
timeout-minutes: 25

name: Test on Node.js ${{ matrix.node-version }}
name: Test on Node.js ${{ matrix.node-version }} (${{ matrix.os }})
steps:
- name: Checkout codes
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion specs/utils/nuxt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export async function loadFixture(testContext: VitestContext) {
...(ctx.options.prerender ? { static: true } : {}),
output: {
dir: outputDir,
...(ctx.options.prerender ? { publicDir: outputDir + '/public' } : {})
...(ctx.options.prerender ? { publicDir: resolve(outputDir, 'public') } : {})
}
}
})
Expand Down
2 changes: 1 addition & 1 deletion specs/utils/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export async function startServer(env: Record<string, unknown> = {}) {
ctx.serverProcess.kill()
throw lastError || new Error('Timeout waiting for dev server!')
} else if (ctx.options.prerender) {
const command = `npx serve ${ctx.nuxt!.options.nitro!.output?.publicDir} -l tcp://${host}:${port} --no-port-switching`
const command = `pnpx serve ${ctx.nuxt!.options.nitro!.output?.publicDir} -l tcp://${host}:${port} --no-port-switching`
// ; (await import('consola')).consola.restoreConsole()
const [_command, ...commandArgs] = command.split(' ')

Expand Down
Loading