edit : OAuth 로그인 프로세스 변경 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlswns2480
approved these changes
Apr 16, 2024
| SEVENTY("70~79", "70-79", "70대"), | ||
| EIGHTY("80~89", "80-89", "80대"), | ||
| NINETY("90~", "90-", "90이상"); | ||
| UNKNOWN("0", "0", "알 ㅅ 없음", 0), |
Comment on lines
52
to
60
| for (AgeGroup a : values()) { | ||
| //현재 연령대의 사용자의 나이가 포함된다면 | ||
| if (a.getMaxAge()>=age) { | ||
| userAgeGroup = a; | ||
| } | ||
| } | ||
| return userAgeGroup; | ||
|
|
||
| } |
There was a problem hiding this comment.
return문이 if문 안에 있어야 정상 흐름 아닌가욥??
There was a problem hiding this comment.
break 건 다는걸 놓쳤네요..!! 감사합니다~!
정적 팩토리 메서드를 다 수정해야 줘야 한다 생각했는데, 지금 생각해보니 그냥 하나 더 만들면 되겠네요!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛏ 작업 상세 내용
✅ 중점적으로 리뷰 할 부분
참고사항