Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for HighFive v3. #513

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prepare for HighFive v3. #513

wants to merge 2 commits into from

Conversation

1uc
Copy link
Contributor

@1uc 1uc commented Nov 11, 2024

No description provided.

@1uc
Copy link
Contributor Author

1uc commented Nov 11, 2024

@mgeplf what does one do about the coverage drop? It seems like the usual issue of reducing the total number of lines by removing covered lines, leads to a decrease in coverage (by numbers).

@mgeplf
Copy link
Contributor

mgeplf commented Nov 21, 2024

what does one do about the coverage drop? It seems like the usual issue of reducing the total number of lines by removing covered lines, leads to a decrease in coverage (by numbers).

it's an annoying effect of using the ratio, for sure.
I personally add a couple tests, since so much is not covered at the moment.
I don't expect you to do that, though - I will have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants