Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base64 encoding in preference to ascii85 for v2 protocol #28

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

JamieDriver
Copy link
Collaborator

@JamieDriver JamieDriver commented Feb 14, 2024

Use base64 encoding rather than base85.

@greenaddress
Copy link
Contributor

utack e4a8030

This encoding is slightly less space-efficient but avoids special
characters (notably quotes) that may cause issues for some parsers
and cbor->json converters.
@JamieDriver JamieDriver merged commit d761777 into master Mar 14, 2024
1 check passed
@JamieDriver JamieDriver deleted the base64 branch March 14, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants