This repository has been archived by the owner on Jun 29, 2024. It is now read-only.
given_skills added to classes (attempt 2) #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an attempt to be able to find a class's skills tested and it works w/ rouge, kinda new to code base but im assuming we can tell what job/class somebody is? given thats the case, /type:: can call given_skills or stats_given if not i can try and add a text ref to the class they are
also added warrior, ig im making a faux const, but i don't think theres massive instances of these classes(?) so having them shouldn't be a big deal?
tested the job, after_spawn() does take care of it. didnt test adjust_experience() i assume from looking it works the same as adjust_skillrank() idk
also warrior and rouge have both the stat and skills. amazon is there. I DID NOT TEST change_stat!!! COMPILE->TEST pipeline is like 3 mins for me
ChungusGamer666
suggested changes
May 23, 2024
code/modules/jobs/job_types/roguetown/adventurer/types/combat/amazon.dm
Outdated
Show resolved
Hide resolved
| // H.mind.adjust_skillrank(/datum/skill/misc/riding, pick(2,3), TRUE) | ||
| // H.mind.adjust_skillrank(/datum/skill/misc/medicine, 1, TRUE) | ||
|
|
||
| H.mind.assign_experiences(/datum/advclass/sfighter::stat_changes, TRUE, "Stats") |
There was a problem hiding this comment.
oh look its the funny new operator!
...does it even work with lists? i know for a fact initial() refuses to work with lists
There was a problem hiding this comment.
on children yes, on parent it throws a runtime
`
/datum/test
var/list/given_skills = list()
/datum/test/child
given_skills = list("blah" =1 , "halb" = 2)
/mob/verb/test()
world<<jointext(/datum/test/child::given_skills, " , ")
`
does result in: blah , halb
ChungusGamer666
added
the
hallowed
|
all other jobs/classes have to b updated. ill prob get around to it this weekend if this all checks |
|
fix conflicts and this should be good to testmerge |
|
should b good |
|
testmerging this |
ChungusGamer666
changed the title
|
epic merge conflicts wtf |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
an attempt to be able to find a class's skills
tested and it works w/ rouge, kinda new to code base but im assuming we can tell what job/class somebody is? given thats the case, /type:: can call given_skills or stats_given if not i can try and add a text ref to the class they are
the idea: add given_skills and stats_given to the advclass datum / perhaps to job as well, not sure how jobs tie into this codebase yet
use these lists as both a ref and a way to apply stats/skills
the dream: easier to adjust skills/stats
capable of finding skills/stats of a class
Why It's Good For The Game
makes code life easier ig, i seen this and decided to take a shot at it.
in the long run it'll b a lot of replacing chunks of code which may b easy with a regex or something