chore(root): add eslint rule to restrict sinon usage #5495
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahin-mohammad
previously approved these changes
Feb 10, 2025
.eslintrc.json
Outdated
| "error", | ||
| { | ||
| "name": "require", | ||
| "message": "Requiring sinon is not allowed. Use other mocking libraries.", |
There was a problem hiding this comment.
Suggested change
| "message": "Requiring sinon is not allowed. Use other mocking libraries.", | |
| "message": "Requiring sinon is not allowed. Use other mocking libraries, such as x,y or z.", |
Please give an exmaple of the alternatives in the message itself.
kev-daniell
force-pushed
the
DX-1013-add-eslint-rules-to-restrict-sinon-additions
branch
from
e3f8bee to
0759087
Compare
zahin-mohammad
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: DX-1013
TICKET: DX-1013