Update the test-case

Signed-off-by: Andy Kwok <[email protected]>
Bit-Quill · Feb 7, 2025 · c52db67 · c52db67
1 parent 701e073
commit c52db67
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 17 deletions.
diff --git a/core/src/main/java/org/opensearch/sql/expression/json/JsonFunctions.java b/core/src/main/java/org/opensearch/sql/expression/json/JsonFunctions.java
@@ -60,8 +60,6 @@ private DefaultFunctionResolver jsonExtract() {
   private DefaultFunctionResolver jsonSet() {
     return define(
         BuiltinFunctionName.JSON_SET.getName(),
-
-        // Numeric types
         impl(nullMissingHandling(JsonUtils::setJson), UNDEFINED, STRING, STRING, BYTE),
         impl(nullMissingHandling(JsonUtils::setJson), UNDEFINED, STRING, STRING, SHORT),
         impl(nullMissingHandling(JsonUtils::setJson), UNDEFINED, STRING, STRING, INTEGER),

diff --git a/core/src/main/java/org/opensearch/sql/utils/JsonUtils.java b/core/src/main/java/org/opensearch/sql/utils/JsonUtils.java
@@ -140,7 +140,15 @@ private static ExprValue processJsonNode(JsonNode jsonNode) {
     return LITERAL_NULL;
   }
 
-  /** Converts a JSON encoded string to an Expression object. */
+  /**
+   * Perform an upsert operation against the incoming jsonString value with provided jsonPath and
+   * value.
+   *
+   * @param json jsonObject in String format.
+   * @param path upsert reference in the form of JsonPath.
+   * @param valueToInsert value to be added
+   * @return JsonString after the upsert operation.
+   */
   public static ExprValue setJson(ExprValue json, ExprValue path, ExprValue valueToInsert) {
 
     String jsonString = json.stringValue();

diff --git a/core/src/test/java/org/opensearch/sql/expression/json/JsonFunctionsTest.java b/core/src/test/java/org/opensearch/sql/expression/json/JsonFunctionsTest.java
@@ -295,33 +295,21 @@ void json_set_InsertArray() {
     assertEquals("{\"test\":[\"Alice\",\"Ben\"]}", functionExpression.valueOf().stringValue());
   }
 
-  @Test
-  void json_set_insert_new_property_nested() {
-    FunctionExpression functionExpression =
-        DSL.jsonSet(
-            DSL.literal("{\"members\":[{\"name\":\"alice\"}]}"),
-            DSL.literal("$.members[0].age.innerAge"),
-            DSL.literal("18"));
-    assertEquals(
-        "{\"members\":[{\"name\":\"alice\",\"age\":{\"innerAge\":\"18\"}}]}",
-        functionExpression.valueOf().stringValue());
-  }
-
   @Test
   void json_set_insert_invalid_path() {
     FunctionExpression functionExpression =
         DSL.jsonSet(
             DSL.literal("{\"members\":[{\"name\":\"alice\"}]}"),
             DSL.literal("$$$$$$$$$"),
             DSL.literal("18"));
-    assertThrows(SemanticCheckException.class, () -> functionExpression.valueOf());
+    assertThrows(SemanticCheckException.class, functionExpression::valueOf);
   }
 
   @Test
   void json_set_insert_invalid_jsonObject() {
     FunctionExpression functionExpression =
         DSL.jsonSet(DSL.literal("[xxxx}}}}}"), DSL.literal("$.test"), DSL.literal("18"));
-    assertThrows(SemanticCheckException.class, () -> functionExpression.valueOf());
+    assertThrows(SemanticCheckException.class, functionExpression::valueOf);
   }
 
   @Test