-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle scfv #153
Handle scfv #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. See my comments inline.
return heavy_chain, light_chain | ||
|
||
|
||
if __name__ == "__main__": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add to filename the prefix main.
To easily identify scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain ?
) -> None: | ||
""" | ||
|
||
Takes an input PDB files and splits it into separate files, one per describe chain, allowing to rename the chains if desired |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a copied description?
Is it only relevant to complexes with antibodies?
Does it assume that input heavy chain id is H and light is L?
What does it mean output_pdb_path_extensionless? and passthrough_chains?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it was just a copied description, fixing it now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does not assume anything about chain names, you can customize everything through the arguments
anarci_executable = join(dirname(sys.executable), "ANARCI") | ||
if not isfile(anarci_executable): | ||
raise Exception( | ||
f"ANARCI binary not found in {dirname(sys.executable)}. check installation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it part of our requirements? if not add here an explanation of how to install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is part of the requirement, will add instructions
|
||
if 0 == len(light_chain): | ||
raise Exception("ANARCI could not find the light chain domain") | ||
# assert len(heavy_chains) == len(light_chains) == len(sequences) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
No description provided.