Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle scfv #153

Merged
merged 11 commits into from
Jan 14, 2025
Merged

Handle scfv #153

merged 11 commits into from
Jan 14, 2025

Conversation

YoelShoshan
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@mosheraboh mosheraboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See my comments inline.

return heavy_chain, light_chain


if __name__ == "__main__":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add to filename the prefix main.
To easily identify scripts.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain ?

) -> None:
"""

Takes an input PDB files and splits it into separate files, one per describe chain, allowing to rename the chains if desired
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a copied description?
Is it only relevant to complexes with antibodies?
Does it assume that input heavy chain id is H and light is L?
What does it mean output_pdb_path_extensionless? and passthrough_chains?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it was just a copied description, fixing it now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not assume anything about chain names, you can customize everything through the arguments

anarci_executable = join(dirname(sys.executable), "ANARCI")
if not isfile(anarci_executable):
raise Exception(
f"ANARCI binary not found in {dirname(sys.executable)}. check installation"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it part of our requirements? if not add here an explanation of how to install.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is part of the requirement, will add instructions


if 0 == len(light_chain):
raise Exception("ANARCI could not find the light chain domain")
# assert len(heavy_chains) == len(light_chains) == len(sequences)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@YoelShoshan YoelShoshan merged commit 25cb2ce into main Jan 14, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants