-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make images sticky by default #904
base: Development
Are you sure you want to change the base?
Conversation
…n from anchorFloatDiv to floatImgDiv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, the image doesn't seem to be sticky until I click the anchor button:
I think that the ticket wants it to start out as sticky (with the user being able to opt of out of this behavior).
Is it different on your side, @NikitaSalikov ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few more comments.
?> | ||
|
||
<script> | ||
|
||
$(document).ready(function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to do this without jQuery?
Also, the left attribute stil doesn't seem to be quite enough on my screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really happy with the sticky behavior, and I'm ok with the draggable behavior.
However, when I make my screen really small, the image disappears from the viewport, and I can't scroll to access it. Is there any way to fix that behavior?
Changes Made:
added a class to fieldset to default to sticky
switched hidden button from anchorFloatDiv to floatImgDiv
Pull Request Checklist:
Pre-Approval
master
branch and squash and merged back into themaster
branch.Development
branch, NOTmaster
https://github.com/orgs/BioKIC/projects/6/views/14?pane=issue&itemId=29044724
Post-Approval
Development
branch, remember to use the squash & merge optionDevelopment
branch into the master branch, remember to use the merge optionmaster
branch, a subsequent PR frommaster
intoDevelopment
should be made merge option (i.e., no squash).Development
branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock theDevelopment
branch to prevent accidental merges while QA takes place. Follow the release protocol here.Thanks for contributing and keeping it clean!