-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2010, Adds simple popup to assist with color recognition #2027
base: Development
Are you sure you want to change the base?
Conversation
# Issue #2010 # Summary Hooks into the macrostrat api to pull lat long input when the macrostrat layer is clicked.
Seems to be working, but this raises the question...where is the color key for the macrostrat layers? |
js/symb/leafletMap.js
Outdated
<div> | ||
<span><b>Macrostrat ID: </b></span> | ||
<div style="margin-top:1rem"> | ||
<span style="font-weight:bold">Macrostrat matched names: </span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"names" --> "units"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One adjustment left. Looks wonderful!!
Issue #2010
Summary
Hooks into the macrostrat api to pull lat long input when the macrostrat layer is clicked.
First Pass basic
Currently Looks Like
Still need feedback on what is that popup and then I can design up a style for it.
Pull Request Checklist:
Pre-Approval
master
branch and PR'd using the merge option (not squashed) into thehotfix
branch.Development
branch, NOTmaster
Post-Approval
Development
branch, remember to use the squash & merge optionhotfix
branch, remember to use the merge option (i.e., no squash).Development
branch into the master branch, remember to use the merge optionhotfix
branch into themaster
branch use the squash & merge optionmaster
intoDevelopment
should be made with the merge option (i.e., no squash).hotfix
branch and create a newhotfix
branchhotfix
branch.Development
branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock theDevelopment
branch to prevent accidental merges while QA takes place. Follow the release protocol here.Thanks for contributing and keeping it clean!