Association schema adjustment

[egbot]

• Adjust schema to remove association record whenever either internal association is deleted. Current schema sets occidAssociate field to null when linked occurrence is deleted, thus resulting in non-informative orphaned associations.

Pull Request Checklist:

Pre-Approval

• There is a description section in the pull request that details what the proposed changes do. It can be very brief if need be, but it ought to exist.
• Hotfixes should be branched off of the master branch and squash and merged back into the master branch.
• Features and backlog bugs should be merged into the Development branch, NOT master
• All new text is preferably internationalized (i.e., no end-user-visible text is hard-coded on the PHP pages), and the spreadsheet tracking internationalizations has been updated either with a new row or with checkmarks to existing rows.
• There are no linter errors
• New features have responsive design (i.e., look aesthetically pleasing both full screen and with small or mobile screens)
• Symbiota coding standards have been followed
• If any files have been reformatted (e.g., by an autoformatter), the reformat is its own, separate commit in the PR
• Comment which GitHub issue(s), if any does this PR address
• If this PR makes any changes that would require additional configuration of any Symbiota portals outside of the files tracked in this repository, make sure that those changes are detailed in this document.

Post-Approval

• It is the code author's responsibility to merge their own pull request after it has been approved
• If this PR represents a merge into the Development branch, remember to use the squash & merge option
• If this PR represents a merge from the Development branch into the master branch, remember to use the merge option
• If this PR represents a hotfix into the master branch, a subsequent PR from master into Development should be made merge option (i.e., no squash).
• If the dev team has agreed that this PR represents the last PR going into the Development branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock the Development branch to prevent accidental merges while QA takes place. Follow the release protocol here.
• Don't forget to delete your feature branch upon merge. Ignore this step as required.

Thanks for contributing and keeping it clean!

[Atticus29]

I'm a little confused. It seems like there's a mismatch between the description and the code.

The description

Adjust schema to remove association record whenever either internal association is deleted. Current schema sets occidAssociate field to null when linked occurrence is deleted, thus resulting in non-informative orphaned associations.

makes it sound like what is desired is to delete the association record if the occurrence corresponding to either occid or occidAssociate are deleted.

What I think would happen instead is that the user could no longer delete the occurrence, creating user, or editing user if the association exists, forcing the end user to have to delete the association first. Is this the desired behavior?

[egbot]

I'm a little confused. It seems like there's a mismatch between the description and the code.

The description

Adjust schema to remove association record whenever either internal association is deleted. Current schema sets occidAssociate field to null when linked occurrence is deleted, thus resulting in non-informative orphaned associations.

makes it sound like what is desired is to delete the association record if the occurrence corresponding to either occid or occidAssociate are deleted.

What I think would happen instead is that the user could no longer delete the occurrence, creating user, or editing user if the association exists, forcing the end user to have to delete the association first. Is this the desired behavior?

Yes, this PR is from prior to our last Dev meeting, where we decided that we would play it safer and restrict, but we also also realized that we needed to review the behaviors of the current controls, as well as the occurrence remapping tools. I'll switch this over to draft for now, until we reach an agreement on the best actions. However, within your dev environment, you probably want to change the FK to restrict, and delete the orphaned internal associations (null occidAssociate), which shouldn't exist nor be allowed.