-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades BAP to janestreet v0.16 libraries #1602
base: master
Are you sure you want to change the base?
Upgrades BAP to janestreet v0.16 libraries #1602
Conversation
6a873d1
to
c172d62
Compare
@ivg pinging just to make you aware of this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through all the changes, they look pretty syntactical. I wonder what could get wrong that ppc tests fail.
@bmourad01 do you plan to update/finish the PR? |
c172d62
to
69b3408
Compare
I believe it should be ready now. I put extra constraints on the versions of the libraries (we don't want to allow Later in the future we can have more discussion about what needs to be done to move BAP to be ready for OCaml 5 (but it seems that this would mean abandoning support for OCaml 4). |
I wouldn't mind this, if we can jump forward to OCaml 5 and forfeit any support for OCaml 4.x. |
Related: #1589
This is here as a placeholder for now in case we want to upgrade to v0.16.0 version ofIt is desirable to keep the version of janestreet libraries (such asbase
,core
,core_kernel
, and other related libraries.base
,core
, andcore_kernel
) as current as possible.Several interfaces have been changed/broken as far as I can see, namely:
X.Set
,X.Map
, andX.Table
have been gutted of various functions that are present inSet
,Map
, andHashtbl
, respectivelySkip
andYield
constructors forSequence.Step.t
each expect an inline record for their arguments.Binable.Of_binable
,Binable.Of_stringable
, andBin_prot.Make_binable
are gone and now have{with,without}_uuid
and other variants. Thewithout_uuid
is marked as "legacy" in the compiler warnings, stating thatwith_uuid
is preferred. I'm leaving it as the former for now as it doesn't require us to change anything else for these functor applications.Caml
is now deprecated in favor ofStdlib
Right now some of the PowerPC unit tests are failing on my end, so I will try to investigate later when I have time (actually, it seems that they are failing without this change. I'm not sure if this is due to a change in newer versions of LLVM or something else).See #1603, can be merged independently.