Fixing #42: Status bar white on Lollipop (Fixing Side effect)

BijoySingh · Jan 18, 2018 · aa99d78 · aa99d78
1 parent b489f62
commit aa99d78
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -9,8 +9,8 @@ android {
         applicationId "com.bijoysingh.quicknote"
         minSdkVersion 17
         targetSdkVersion 27
-        versionCode 42
-        versionName "4.1.3"
+        versionCode 43
+        versionName "4.1.4"
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
         javaCompileOptions {
             annotationProcessorOptions {

diff --git a/app/src/main/java/com/bijoysingh/quicknote/activities/ThemedActivity.kt b/app/src/main/java/com/bijoysingh/quicknote/activities/ThemedActivity.kt
@@ -25,9 +25,8 @@ abstract class ThemedActivity : AppCompatActivity() {
   }
 
   fun setSystemTheme() {
-    val backgroundColor = getThemeColor()
     if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
-      window.statusBarColor = backgroundColor
+      window.statusBarColor = getStatusBarColor()
     }
 
     if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
@@ -40,7 +39,11 @@ abstract class ThemedActivity : AppCompatActivity() {
   }
 
   fun getThemeColor(): Int {
-    val lightColor = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) R.color.white else R.color.material_grey_400
+    return getColor(R.color.white, R.color.material_grey_800)
+  }
+
+  fun getStatusBarColor(): Int {
+    val lightColor = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) R.color.white else R.color.material_grey_500
     return getColor(lightColor, R.color.material_grey_800)
   }