Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 网络测试页面延迟后增加info图标 #3544

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Conversation

luojunyuan
Copy link
Contributor

@luojunyuan luojunyuan commented Nov 19, 2024

image

增加了一个值转换器,在 namespace BD.WTTS.UI 命名空间下。

@luojunyuan
Copy link
Contributor Author

修改保持最小变更,在不改变原有业务逻辑的基础上进行,不做任何重构。

@luojunyuan
Copy link
Contributor Author

实现的效果:
{F1930BAF-EFFA-4F8D-B04F-5D5209D8E8C0}
这里 ASFService.Current.DownloadASFAsync() 方法传入 CancelToken 取消后没办法再度重新下载,就没设置取消按钮了。

@luojunyuan luojunyuan requested a review from rmbadmin November 21, 2024 03:39
Copy link
Member

@rmbadmin rmbadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StringNotEmptyToVisibilityConverter 是不必要的添加 应使用已有的 IsNullConverter

Copy link
Contributor Author

@luojunyuan luojunyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@luojunyuan luojunyuan requested a review from rmbadmin November 22, 2024 02:26
@rmbadmin rmbadmin merged commit 08ffcfc into develop Nov 25, 2024
1 check passed
@luojunyuan luojunyuan deleted the feature/info_icon branch November 27, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants