Bing Search Pass Thru #8019
Open
Bing Search Pass Thru #8019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ishaan-jaff
requested changes
Jan 27, 2025
| @@ -325,6 +327,25 @@ async def pass_through_request( # noqa: PLR0915 | |||
| request=request, headers=headers, forward_headers=forward_headers | |||
| ) | |||
|
|
|||
| if merge_query_params: | |||
| # Get the query params from the request | |||
There was a problem hiding this comment.
can you make a helper function for doing this and call the helper
| @@ -2175,6 +2175,7 @@ class SpecialHeaders(enum.Enum): | |||
| azure_authorization = "API-Key" | |||
| anthropic_authorization = "x-api-key" | |||
| google_ai_studio_authorization = "x-goog-api-key" | |||
| bing_search_authorization = "Ocp-Apim-Subscription-Key" | |||
There was a problem hiding this comment.
this should be apim_authorization header correct
I believe all apim requests can use this header ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Enables Bing Search as a pass-thru endpoint
Type
🆕 New Feature
Changes
Ocp-Apim-Subscription-Keya valid for looking up a key (https://learn.microsoft.com/en-us/bing/search-apis/bing-web-search/reference/headers)merge_query_paramsto pass thru endpoints so we can pass the search string thru.[REQUIRED] Testing - Attach a screenshot of any new tests passing locally
If UI changes, send a screenshot/GIF of working UI fixes
unclear why there is so much output.