Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(perf - RPS improvement) #7930

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

(perf - RPS improvement) #7930

wants to merge 13 commits into from

Conversation

ishaan-jaff
Copy link
Contributor

@ishaan-jaff ishaan-jaff commented Jan 22, 2025

(perf - RPS improvement) - Don't allow slow logging / callback integrations to block main LLM API Calls

Screenshot 2025-01-22 at 5 42 58 PM Screenshot 2025-01-22 at 5 43 04 PM

Scenario

  • Logging integration is hanging, takes 60s to respond
  • Send 100 RPS
  • Prev, requests would hang

Changes

  • Schedule the async_success_handler(...) to run on the dedicated async loop. (prev it ran on main event loop)
  • Schedule any synchronous logging via the ThreadPoolExecutor.

Relevant issues

Type

🆕 New Feature
✅ Test

Changes

[REQUIRED] Testing - Attach a screenshot of any new tests passing locally

If UI changes, send a screenshot/GIF of working UI fixes

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 4:16am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant