Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance collaboration DX through devcontainer #63

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

CamillePressense
Copy link
Contributor

@CamillePressense CamillePressense commented Dec 3, 2024

(@mpressen, owner, inside).

Currently this account 'CamillePressense' is not yet linked to Benefactorum organisation.

  1. setup project as an opensource one that can welcome contributions #58 🟢
    I'm not able to push to main
    image
    But I can push to another branch. Then I can't create a PR from it.

1bis. --> standard workflow : After forking the project, I'm able to create a branch and a PR (this one youhou 🎆 )

  1. Set up a devcontainer for Benefactorum #30
    This PR enables devcontainer to ease onboarding.

Todos:
[x] block branch creation from guests.
[x] add a proper README

@mpressen mpressen requested a review from Copilot December 3, 2024 20:47
@mpressen mpressen self-assigned this Dec 3, 2024
@mpressen mpressen added documentation Improvements or additions to documentation enhancement New feature or request infra labels Dec 3, 2024
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 suggestion.

Files not reviewed (1)
  • .devcontainer/devcontainer.json: Language not supported

app/services/captcha.rb Outdated Show resolved Hide resolved
@mpressen mpressen merged commit c3dcae7 into Benefactorum:main Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants