Improve type safety and input validation across frontend components

- Enhanced type definitions in Layout, OsblDatasheet, and other components
- Updated input types for website and URL fields with placeholders
- Refined type annotations in MyAsyncSelect and other shared components
- Improved error handling and type safety in various form input methods
- Updated Inertia page resolution to throw an error for missing pages
- Cleaned up commented-out validation and code comments

app/frontend/Layout.tsx

@@ -10,13 +10,13 @@ const flashTypes = ['message', 'success', 'info', 'warning', 'error'] as const
 
 interface LayoutProps {
   showSidebar: boolean
-  flash: any
+  flash: { [key in typeof flashTypes[number]]?: string }
   children?: ReactElement
 }
 
 export default function Layout ({
   children,
-  showSidebar = false,
+  showSidebar,
   flash = {}
 }: LayoutProps): ReactElement {
   useEffect(() => {

app/frontend/components/pages/contribution/new/OsblDatasheet.tsx

@@ -84,8 +84,8 @@ export default function OsblDatasheet ({ data, setData, errors, clearErrors }: O
         <div className='flex flex-col gap-4'>
           <Label>Réduction d'impôt * :</Label>
           <RadioGroup
-            required // doesn't work as expected
-            value={String(data.tax_reduction)}
+            required // doesn't work. Comment kept for reference
+            value={data.tax_reduction}
             onValueChange={(value) => {
               setData('tax_reduction', value)
               clearErrors('tax_reduction')

app/frontend/components/pages/contribution/new/OsblFinances/FundManagementSection.tsx

@@ -33,7 +33,7 @@ export default function FundManagementSection ({
   errors,
   clearErrors
 }: FundManagementSectionProps): ReactElement {
-  function handleFundChange (index: number, field: keyof FundRecord, value: any): void {
+  function handleFundChange (index: number, field: keyof FundRecord, value: FundRecord[keyof FundRecord]): void {
     const updatedItems = items.map((item: FundRecord, i: number) =>
       i === index ? { ...item, [field]: value } : item
     )

app/frontend/components/pages/contribution/new/OsblFinances/OsblFinanceSheet.tsx

@@ -25,7 +25,6 @@ interface Props extends Omit<FormProps, 'setData'> {
   onUpdate: (finance: AnnualFinance) => void
 }
 
-// Fix the return type and validation
 const financeValidation = (data: AnnualFinance[], currentIndex: number): z.ZodType<any> => z.object({
   year: z.string().refine(
     (year) =>

app/frontend/components/pages/contribution/new/OsblHeader.tsx

@@ -26,8 +26,9 @@ export default function OsblHeader ({ data, setData, errors, clearErrors }: Omit
 
         <MyInput
           id='website'
-          type='text'
+          type='url'
           labelText='Site internet :'
+          placeholder='https://'
           value={data.website ?? ''}
           onChange={(e) => {
             setData('website', e.target.value)

app/frontend/components/pages/contribution/new/OsblLocations/OsblLocationSheet.tsx

@@ -54,7 +54,7 @@ export default function OsblLocationSheet ({
     return checks.some(check => check)
   })
 
-  function updateSheetLocation (field: keyof Location, value: any): void {
+  function updateSheetLocation<K extends keyof Location> (field: K, value: Location[K]): void {
     setSheetLocation(prev => ({
       ...prev,
       [field]: value
@@ -79,13 +79,15 @@ export default function OsblLocationSheet ({
     onUpdate(deepCleanData(sheetLocation))
   }
 
-  function getLabel (): string {
-    return [
+  function getLabel (): string | undefined {
+    const label = [
       sheetLocation.address_attributes?.street_number,
       sheetLocation.address_attributes?.street_name,
       sheetLocation.address_attributes?.postal_code,
       sheetLocation.address_attributes?.city
     ].filter(Boolean).join(' ')
+
+    return label.length > 0 ? label : undefined
   }
 
   return (
@@ -174,6 +176,7 @@ export default function OsblLocationSheet ({
                 <MyInput
                   labelText='Site web'
                   type='url'
+                  placeholder='https://'
                   id={`location-website-${index}`}
                   value={sheetLocation.website ?? ''}
                   onChange={(e) => updateSheetLocation('website', e.target.value)}

app/frontend/components/shared/MyAsyncSelect.tsx

@@ -31,7 +31,7 @@ interface MyAsyncCreatableSelectProps {
   minInputLength?: number
   placeholder?: string
   required?: boolean
-  value: string
+  value: string | undefined
 }
 
 const createOption = (feature: AddressFeature): Option => ({

app/frontend/components/shared/MyFileInput.tsx

@@ -33,9 +33,6 @@ export default function MyFileInput ({
     if (inputRef.current != null) {
       inputRef.current.value = ''
       setHasFile(false)
-      // Trigger onChange with a fake event to notify parent component
-      const event = new Event('change', { bubbles: true }) as unknown as React.ChangeEvent<HTMLInputElement>
-      Object.defineProperty(event, 'target', { value: { value: '', files: null } })
     }
     onChange(undefined)
   }

app/frontend/lib/inertiaConfig.ts

@@ -19,7 +19,7 @@ export const resolvePage: PageResolver = (name) => {
   const page = pages[`../pages/${name}.tsx`]
 
   if (page === undefined) {
-    console.error(`Missing Inertia page component: '${name}.tsx'`)
+    throw new Error(`Page ${name}.tsx not found`)
   }
 
   page.default.layout = (pageContent) =>

app/models/location.rb

@@ -13,7 +13,6 @@ class Location < ApplicationRecord
 
   validates :address, presence: true
   # validates :type, presence: true
-  # validates :name, exclusion: {in: [""]}, allow_nil: true
   # validates :name, presence: true, if: -> { type.in?(%i[antenne_locale lieu_d_activite autre]) }
   # validates :osbl, uniqueness: {scope: :type, if: -> { type == "siege_social" }}
 

spec/rails_helper.rb

@@ -38,7 +38,6 @@
   abort e.to_s.strip
 end
 RSpec.configure do |config|
-  # config.include ActionDispatch::TestProcess # for fixture_file_upload
   # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
   config.fixture_paths = [
     Rails.root.join("spec/fixtures")