Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional sensors #289

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

toggm
Copy link

@toggm toggm commented Oct 28, 2024

* Added additional sensors for flow in temperatur and target of circuit 2 and 3
* Added counter of additional heat  generator2

Related to: #285

Example of new sensors:
image

@toggm toggm force-pushed the feature/flow_in_circuit_temperatures branch 2 times, most recently from 78401a2 to 6871771 Compare October 29, 2024 13:47
@toggm
Copy link
Author

toggm commented Nov 5, 2024

image

@toggm toggm force-pushed the feature/flow_in_circuit_temperatures branch from 141e71b to 5f2a59d Compare November 12, 2024 08:00
@blue-bean
Copy link

@BenPru
Can you please merge this commits?

@toggm
Copy link
Author

toggm commented Dec 5, 2024

@BenPru anything missing which prevents you from merging this PR?

@toggm
Copy link
Author

toggm commented Dec 5, 2024

@BenPru Can you please merge this commits?

@blue-bean I marked the dev branch as main branch in my repo. If you want to use those sensors, you can add my repo as a custom repository to HACS in the meantime.

@blue-bean
Copy link

blue-bean commented Dec 15, 2024

@toggm
I've tested your files but with this changes i've the effect that every second start of HA there are some sensors missing (only every second restart - after next restart all sensors working fine). Very strange

@toggm
Copy link
Author

toggm commented Dec 16, 2024

@toggm I've tested your files but with this changes i've the effect that every second start of HA there are some sensors missing (only every second restart - after next restart all sensors working fine). Very strange

@blue-bean I've seen similar behaviour, not sure if it's really related to my chances as I see an exception in a different place. Seems to be a timing issue. But I'll have a look.

@blue-bean
Copy link

blue-bean commented Dec 16, 2024

@toggm
I will test it now with the latest beta 2024.11.15

@blue-bean
Copy link

blue-bean commented Dec 16, 2024

@toggm
Can you push your changes as pull requests to my fork https://github.com/blue-bean/luxtronik_ait ?
I don't know another way to import your pull requests in my local BenPru-repository using Github-Desktop.

@toggm
Copy link
Author

toggm commented Dec 16, 2024

@blue-bean you could either fork my repository of pull my remote branch.
https://stackoverflow.com/questions/1709177/pull-a-certain-branch-from-the-remote-server

The changes are in the feature/flow_in_circuit_temperatures branch.

@toggm
Copy link
Author

toggm commented Dec 16, 2024

@blue-bean I'm missing the following fix which was merged back to main after I forked the repo:
012baaf

I'm now going to rebase.

…it 2 and 3

* Added counter of additional heat  generator2
* Added config parameters of heating curve of mixed circuit number 2
@toggm toggm force-pushed the feature/flow_in_circuit_temperatures branch from 25d384f to e7e7fd6 Compare December 16, 2024 20:56
@toggm
Copy link
Author

toggm commented Dec 16, 2024

@blue-bean Rebasing has fixed the error.
@BenPru what about reviewing/merging this MR?

@blue-bean
Copy link

blue-bean commented Dec 16, 2024

I've merged this changes locally into the latest main branch (2024.11.15) and can confirm that all changes work fine.

@toggm
Copy link
Author

toggm commented Jan 14, 2025

Is someone else able to merge?

@blue-bean
Copy link

I'm afraid not.

@BenPru
Copy link
Owner

BenPru commented Jan 14, 2025

@toggm Please provide a release text to describe the breaking changes. 🙏
Sorry for the delay. Many things around me atm.

@toggm
Copy link
Author

toggm commented Jan 15, 2025

@toggm Please provide a release text to describe the breaking changes. 🙏 Sorry for the delay. Many things around me atm.

@BenPru Thanks for answering. Should I post the release notes here or where do you expect me to document those changes?

@toggm
Copy link
Author

toggm commented Jan 31, 2025

@toggm Please provide a release text to describe the breaking changes. 🙏 Sorry for the delay. Many things around me atm.

@BenPru I've created now a short description about the renaming of the sensors and the newly introduced sensors, hope this will help to be able to merge this PR.

Release notes

This release fixes the naming of the heating circuit sensors.
Before, circuit-1 sensors where in fact sensors of the main heating circuit.
Circuit-2 sensors where point to mixing circuit-1, circuit-3 where pointing to mixing circuit-3.
Mixing circuit-2 was missing at all.

Harmonize naming of circuit sensor names

The following renaming was applied:

  • Main circuit sensors now start without circuit prefix to distinguish them between the mixing circuits
  • Mixing circuit sensors now start with circuit<Number> prefixes
  • Circuit-2 sensors names where renamed to circuit-1 sensors names
  • Naming of Circuit-3 sensors was just harmonized to the same pattern

All Renaming where described in the following issue:
#291

The sensors where renamed as follow:

Entity name before Renamed to
sensor.<identity_prefix>_heating_circuit_curve1_temperature sensor.<identity_prefix>_heating_curve_end_temperature
sensor.<identity_prefix>_heating_circuit_curve2_temperature sensor.<identity_prefix>_heating_curve_parallel_shift_temperature
sensor.<identity_prefix>_heating_circuit_curve_night_temperature sensor.<identity_prefix>_heating_curve_night_temperature
sensor.<identity_prefix>_heating_circuit2_curve1_temperature sensor.<identity_prefix>_heating_curve_circuit1_end_temperature
sensor.<identity_prefix>_heating_circuit2_curve2_temperature sensor.<identity_prefix>_heating_curve_circuit1_parallel_shift_temperature
sensor.<identity_prefix>_heating_circuit2_curve_night_temperature sensor.<identity_prefix>_heating_curve_circuit1_night_temperature
sensor.<identity_prefix>_heating_circuit3_curve1_temperature sensor.<identity_prefix>_heating_curve_circuit3_end_temperature
sensor.<identity_prefix>_heating_circuit3_curve2_temperature sensor.<identity_prefix>_heating_curve_circuit3_parallel_shift_temperature
sensor.<identity_prefix>_heating_circuit3_curve_night_temperature sensor.<identity_prefix>_heating_curve_circuit3_night_temperature

The history will update itself. All other custom integrations (dashboard, automations, helpers, templates, ...) need to be migrated manually.

Introducing new sensors

The following sensors where newly introduced:

New entity Description
sensor.<identity_prefix>_heating_curve_circuit2_end_temperature Target end temperature of mixing circuit 2
sensor.<identity_prefix>_heating_curve_circuit2_parallel_shift_temperature Parallel shift temperature of mixing circuit 2
sensor.<identity_prefix>_heating_curve_circuit2_night_temperature Night temperature shift of mixing circuit 2
sensor.<identity_prefix>_flow_in_circuit1_temperature Flow-in temperature of mixing circuit 1
sensor.<identity_prefix>_flow_in_circuit2_temperature Flow-in temperature of mixing circuit 2
sensor.<identity_prefix>_flow_in_circuit3_temperature Flow-in temperature of mixing circuit 3
sensor.<identity_prefix>_flow_in_circuit1_target_temperature Flow-in target temperature of mixing circuit 1
sensor.<identity_prefix>_flow_in_circuit2_target_temperature Flow-in target temperature of mixing circuit 2
sensor.<identity_prefix>_flow_in_circuit3_target_temperature Flow-in target temperature of mixing circuit 3
additional_heat_generator2_operation_hours Heat generator 2 operation hours

@AJediIAm
Copy link
Contributor

AJediIAm commented Feb 1, 2025

To my knowledge, renaming an entity will only effect new installs. It shouldn't effect existing entities, so this shouldn't be a breaking change.

Is my assumption wrong?

Secondly, I'm always struggling to visualize what the entities mean. @toggm : Do you happen to have a drawing with the sensors on a basic heatpump layout? I can create a nice picture out of it and update the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants