-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added additional sensors #289
base: main
Are you sure you want to change the base?
Conversation
78401a2
to
6871771
Compare
141e71b
to
5f2a59d
Compare
@BenPru |
@BenPru anything missing which prevents you from merging this PR? |
@blue-bean I marked the dev branch as main branch in my repo. If you want to use those sensors, you can add my repo as a custom repository to HACS in the meantime. |
@toggm |
@blue-bean I've seen similar behaviour, not sure if it's really related to my chances as I see an exception in a different place. Seems to be a timing issue. But I'll have a look. |
@toggm |
@toggm |
@blue-bean you could either fork my repository of pull my remote branch. The changes are in the |
@blue-bean I'm missing the following fix which was merged back to main after I forked the repo: I'm now going to rebase. |
…it 2 and 3 * Added counter of additional heat generator2
* Added config parameters of heating curve of mixed circuit number 2
25d384f
to
e7e7fd6
Compare
@blue-bean Rebasing has fixed the error. |
I've merged this changes locally into the latest main branch (2024.11.15) and can confirm that all changes work fine. |
Is someone else able to merge? |
I'm afraid not. |
@toggm Please provide a release text to describe the breaking changes. 🙏 |
@BenPru I've created now a short description about the renaming of the sensors and the newly introduced sensors, hope this will help to be able to merge this PR. Release notesThis release fixes the naming of the heating circuit sensors. Harmonize naming of circuit sensor namesThe following renaming was applied:
All Renaming where described in the following issue: The sensors where renamed as follow:
Introducing new sensorsThe following sensors where newly introduced:
|
To my knowledge, renaming an entity will only effect new installs. It shouldn't effect existing entities, so this shouldn't be a breaking change. Is my assumption wrong? Secondly, I'm always struggling to visualize what the entities mean. @toggm : Do you happen to have a drawing with the sensors on a basic heatpump layout? I can create a nice picture out of it and update the documentation. |
Related to: #285
Example of new sensors: