Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] change disable to toggle #418

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

flaree
Copy link
Member

@flaree flaree commented Sep 16, 2024

closes #415

Copy link
Contributor

@ltzmax ltzmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove it from being optional to use enabled: ? Right now based on the wording, it says to redo the command to re enable, which might be confusing for our user base?

R641c8

@userandaname
Copy link
Contributor

Maybe we can remove it from being optional to use enabled: ? Right now based on the wording, it says to redo the command to re enable, which might be confusing for our user base?

R641c8

i'm not the one to really say here, but i'd say that it'd make more sense to make it optional in the case that users are already used to /config enable, and so bot-hosters forking BallsDex may want to change that option based on their user-base?

@laggron42
Copy link
Member

i'm not the one to really say here, but i'd say that it'd make more sense to make it optional in the case that users are already used to /config enable, and so bot-hosters forking BallsDex may want to change that option based on their user-base?

It's going to be super hard to have two conditional blocks of code, if self hosters don't like the way we're going they're free to fork/stop updating, we focus on our own user base. I try to consider the selfhosters when adding or changing stuff, but having this sort of switch is really overcomplicated for nothing.

@ltzmax ltzmax added package:config All /config commands (server settings) priority:normal labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:config All /config commands (server settings) priority:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename /config disable to /config toggle
4 participants