Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Models] Add soft delete field #388

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[Models] Add soft delete field #388

wants to merge 4 commits into from

Conversation

flaree
Copy link
Member

@flaree flaree commented Sep 6, 2024

Adds a deleted field to BallInstances

Allows us to mark a ball as deleted without it actually getting deleted and affecting other models such as Trade History etc.

@flaree flaree marked this pull request as draft September 6, 2024 15:34
flaree
flaree commented Sep 9, 2024
View reviewed changes
ballsdex/packages/admin/cog.py Outdated Show resolved Hide resolved
@flaree flaree marked this pull request as ready for review November 25, 2024 09:39
laggron42
laggron42 reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@laggron42 laggron42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to commit the new column in models.py, not sure how pyright validated this

@laggron42 laggron42 linked an issue Nov 28, 2024 that may be closed by this pull request
Players shouldn't get fully deleted with delete command #346
Open
@flaree
Copy link
Member Author

flaree commented Nov 29, 2024

I think you forgot to commit the new column in models.py, not sure how pyright validated this

image
?

@laggron42
Copy link
Member

I think you forgot to commit the new column in models.py, not sure how pyright validated this

image ?

My bad, Github wasn't showing me the full changes

@flaree flaree requested a review from laggron42 January 2, 2025 13:12
@flaree flaree marked this pull request as draft January 2, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laggron42 laggron42 Awaiting requested review from laggron42

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Players shouldn't get fully deleted with delete command
2 participants
@flaree @laggron42