num2words: linting and -th ordinal_num fix for en #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ballasi
reviewed
Dec 11, 2023
src/num2words.rs
Outdated
| match Num2Words::parse("not a number") { | ||
| Some(_) => assert!(false), | ||
| None => assert!(true), | ||
| if Num2Words::parse("not a number").is_some() { |
There was a problem hiding this comment.
LGTM on most side here, I am just not a huge fan of the idea of using panic which will 1. stop the unit tests here, without running the other ones and 2. don't report anything if it works.
The following should do a better job:
assert!(Num2Words::parse("not a number").is_none());
assert!(Num2Words::parse("NAN").is_none());There was a problem hiding this comment.
I just fixed https://rust-lang.github.io/rust-clippy/rust-1.74.0/index.html#/assertions_on_constants
I agree your version is better.
There was a problem hiding this comment.
Related comment for tracking: a109dbc#r133143809
|
Fixed |
Ballasi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15, closes #16