Add initial version of RSS plugin #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reefdog
force-pushed
the
4-add-rss-plugin
branch
2 times, most recently
from
287febb to
1c9f964
Compare
slifty
requested changes
Jun 28, 2020
This initial version of the RSS plugin adds: - A control settings area for app owners to set authenticated feed credentials - Attempting to load and validate user data set by the SSO plugin - Attempting to load and use authenticated feed credentials set by the control - Negotiating which feed to use based on authentication status - Fetching and rendering headlines appropriately - Image resources required by BuildFire It is missing, among other things: - The ability to read an article - Any styling or branding - Live verification of the user information read from localStorage Affects #4
reefdog
force-pushed
the
4-add-rss-plugin
branch
from
1c9f964 to
4d22dde
Compare
|
Sweet! Agree and made the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initial version of the RSS plugin adds:
It is missing:
localStorage(i.e., ensuring the user is still an active user by checking the Auth0 API)Steps to Test
Prerequisites: You'll need the username and password for the STAT Plus authenticated feed.
plugins/directory.yarn startFor the next steps (testing authenticated feed), you have to have the SSO Plugin (#5). Assuming you have that setup also, authenticate using that plugin and then come back to this plugin and continue:
console.errorabout missing authenticated feed credentials (which it complains about since it recognizes you're an authenticated user), but the unauthenticated STAT News Headlines should still load as a fallback.Related Issues
Affects #4 (but does not yet resolve)