Skip to content

Commit

Permalink
📝 updated tasks completed flag
Browse files Browse the repository at this point in the history
* the --completed flag was semantically incorrect
* the new flag is --include-completed -i to include completed tasks
* this one is semantically correct since that's what the feature does
  • Loading branch information
BRO3886 committed Jun 18, 2021
1 parent b310d60 commit 8f01e8c
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 7 deletions.
4 changes: 1 addition & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,4 @@ token.json
google-tasks-cli
gtasks
gtasks.exe
bin/freebsd/gtasks-bsd
bin/freebsd/gtasks-mac
bin/mac/gtasks-mac
bin/*
11 changes: 8 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,13 @@ all:
@echo "Building for every OS and Platform"
GOOS=windows GOARCH=386 go build -o ./bin/windows/gtasks.exe
GOOS=linux GOARCH=386 go build -o ./bin/linux/gtasks
GOOS=freebsd GOARCH=386 go build -o ./bin/freebsd/gtasks-bsd
GOOS=darwin GOARCH=amd64 go build -o ./bin/mac/gtasks-mac
GOOS=freebsd GOARCH=386 go build -o ./bin/freebsd/gtasks
GOOS=darwin GOARCH=amd64 go build -o ./bin/mac/gtasks
@echo "Zipping for release"
@tar -czf bin/releases/gtasks_linux.tar.gz LICENSE -C bin/linux gtasks
@tar -czf bin/releases/gtasks_win.tar.gz LICENSE -C bin/windows gtasks.exe
@tar -czf bin/releases/gtasks_mac_amd64.tar.gz LICENSE -C bin/mac gtasks
@tar -czf bin/releases/gtasks_bsd.tar.gz LICENSE -C bin/freebsd gtasks
run:
go run .
global:
Expand All @@ -21,4 +26,4 @@ push:
git commit -m "$m"
git push origin master
release:
gh release create $v './bin/windows/gtasks.exe' './bin/linux/gtasks' './bin/mac/gtasks-mac'
gh release create $v 'bin/releases/gtasks_linux.tar.gz' 'bin/releases/gtasks_win.tar.gz' 'bin/releases/gtasks_bsd.tar.gz' 'bin/releases/gtasks_mac_amd64.tar.gz'
2 changes: 1 addition & 1 deletion cmd/tasks.go
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ var deleteTaskCmd = &cobra.Command{
var showCompletedFlag bool

func init() {
viewTasksCmd.Flags().BoolVarP(&showCompletedFlag, "completed", "c", false, "use this flag to include completed tasks")
viewTasksCmd.Flags().BoolVarP(&showCompletedFlag, "include-completed", "i", false, "use this flag to include completed tasks")
tasksCmd.AddCommand(viewTasksCmd, createTaskCmd, markCompletedCmd, deleteTaskCmd)
rootCmd.AddCommand(tasksCmd)
}
Expand Down

0 comments on commit 8f01e8c

Please sign in to comment.