Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue collar PR: Remove superfluous semicolons and convert tabs to spaces #120

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

javadba
Copy link
Contributor

@javadba javadba commented Jun 11, 2016

… style CRLF.

This is truly a blue collar PR. Just cleaning up those minor details. The diffs are ugly (huge) because of removing the LineFeeds.

After having rebuilt I have:
manually eyeballed about half the files
rebuilt using sbt package
tried out iscala notebook: seems to be ok
tried out an ssc: it starts to run but can not find data (unrelated usability issue)

If this general approach were acceptable, I will manually traverse the remaining 50 or so files to ensure all look fine. The criteria:
leading tabs to 2 spaces
end-of-line semicolons removed
dos2unix type conversion (though I used a sed command to do it)

@javadba javadba changed the title Remove superfluous semicolons, convert tabs to spaces, and remove DOS… Blue collar PR: Remove superfluous semicolons and convert tabs to spaces Jun 11, 2016
@javadba
Copy link
Contributor Author

javadba commented Jun 30, 2016

Due to (a) no feedback and (b) not being merged in a timely manner by the project maintainers this PR is now out of sync with trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant