Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace update to Adapters #83

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Namespace update to Adapters #83

merged 1 commit into from
Oct 14, 2020

Conversation

adecler
Copy link
Member

@adecler adecler commented Oct 13, 2020

Issues addressed by this PR

Closes #82

See issue for details

@adecler adecler added the type:compliance Non-conforming to code guidelines label Oct 13, 2020
@adecler adecler self-assigned this Oct 13, 2020
This was referenced Oct 13, 2020
Merged
Merged
@adecler
Copy link
Member Author

adecler commented Oct 13, 2020

/azp run Socket_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

FraserGreenroyd
FraserGreenroyd approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the checks have passed so happy with this PR, dependants look ok too.

pawelbaran
pawelbaran approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alelom
alelom approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adecler adecler merged commit ffa94e5 into master Oct 14, 2020
@adecler adecler deleted the Socket_Toolkit-#82-NamespaceUpdate branch October 14, 2020 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alelom alelom alelom approved these changes

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@pawelbaran pawelbaran pawelbaran approved these changes

Assignees

@adecler adecler

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Namespace update to Adapters
4 participants
@adecler @alelom @FraserGreenroyd @pawelbaran