Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align to namespace change in Socket Toolkit #874

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

adecler
Copy link
Member

@adecler adecler commented Oct 13, 2020

NOTE: Depends on

BHoM/Socket_Toolkit#83

Test files

Just make sure it still compile once you have changed on both PRs

Additional comments

@pawelbaran , there was no open PR that would interfere with this but let me know if it is a problem. We can easily delay this if needed.

@adecler adecler added the type:compliance Non-conforming to code guidelines label Oct 13, 2020
@adecler adecler self-assigned this Oct 13, 2020
@adecler
Copy link
Member Author

adecler commented Oct 13, 2020

/azp run Revit_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed so I'm happy - @pawelbaran can confirm the bit about clashing stuff.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adecler adecler merged commit e2007e5 into master Oct 14, 2020
@adecler adecler deleted the Socket_Toolkit-#82-NamespaceUpdate branch October 14, 2020 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants