-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Try-catch for Framing element design properties ensuring Bar pull does not crash #487
Add Try-catch for Framing element design properties ensuring Bar pull does not crash #487
Conversation
First issue. This is to avoid crashing when pulling Robot model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would put the try catch around all the contents of this for loop, not just this part, to make sure we do not end up with a similar situation for other framing properties. This is, from line 45 all the way down to line 155.
Or, actually, at least covering all that are trying to extract the properties. This is from current position down to line 148 |
Try and catch moved to include the entire script
@IsakNaslundBh try and catch has been updated as suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as an initial fix to make sure things does not crash.
For #486 to be resolved properly in upcoming PRs.
@IsakNaslundBh to confirm, the following checks are now queued:
|
The check |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following checks are now queued:
There are 11 requests in the queue ahead of you. |
Try catch is added around the if statement that causes the pulling method to crash in Grasshopper when pulling Robot model.
It is encouraged to review and update FramingElementDesignProperties in the future.
NOTE: Depends on
Issues addressed by this PR
Closes #
Test files
Changelog
Additional comments
See issue in LINK