DoesIntersect point vs solid bug fix
#1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BHoMBot check installer |
|
@michal-pekacki to confirm, the following actions are now queued:
|
pawelbaran
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Approving on the basis of discussion with @michal-pekacki, next actions to be taken in a separate PR.
|
@BHoMBot ready-to-merge |
|
@pawelbaran sorry, I didn't understand. |
|
@BHoMBot check ready-to-merge |
|
@pawelbaran to confirm, the following actions are now queued:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #1530
Not very beautiful, but temporary fix for
DoesIntersect- point vs solid overload. Currently there are several overlapping methods in 3 different files (DoesIntersect,IsContatining,IsInRange) and they have to be unified in the future (issue #1465).Test files
Changelog
Additional comments