Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add View Filters #1502

Open
wants to merge 136 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
136 commits
Select commit Hold shift + click to select a range
6525ab7
draft oM classes added
pawelbaran Jan 29, 2024
495685a
draft support for pull of views and view filters added
pawelbaran Jan 29, 2024
48d61ff
draft support for views and view filters added
pawelbaran Jan 29, 2024
08ba4fb
Merge branch 'Revit_Toolkit-#1444-FilterPrototype' of https://github.…
GCRA101 Feb 18, 2024
917cf9f
Add bespoke classes defining graphics settings for new view filters
GCRA101 Feb 19, 2024
fcb57c0
Rename Class FilterWithOverrides to ViewFilterWithOverrides
GCRA101 Feb 19, 2024
1b9d28d
Add FilterRuleType Enumeration
GCRA101 Feb 19, 2024
e70ed56
Move classes FillPattern, FilterRule and LinePattern from Elements to…
GCRA101 Feb 20, 2024
0ed3572
Implement Update of View based on filters and overrides
GCRA101 Feb 20, 2024
561839a
Add minor updates to main classes in Elements namespace
GCRA101 Feb 20, 2024
ae53ef6
Implement Conversion of BHoM classes to Revit
GCRA101 Feb 20, 2024
b38eab0
Add minor updates to BHoM ViewFilterOverrides Class
GCRA101 Feb 20, 2024
54a0143
Update Query/BHoMType.cs class for View and ParameterFilterElement
GCRA101 Feb 20, 2024
07b0fa1
Minor updates to main new classes for View and filtering
GCRA101 Mar 12, 2024
0efa9b0
Merge branch 'Revit_Toolkit-#1444-FilterPrototype' of https://github.…
GCRA101 Apr 18, 2024
4620c1b
Add FilterRuleEvaluatorType Enumeration
GCRA101 Apr 20, 2024
3f2a258
Add FilterValueRule and modify FilterRuleType
GCRA101 Apr 20, 2024
93b92c9
Delete FilterRuleType Enum
GCRA101 Apr 25, 2024
1776342
Create FilterRule classes mirroring Revit API classes
GCRA101 Apr 26, 2024
54d1526
Move FillPattern and LinePattern to the Enums Namespace
GCRA101 Apr 26, 2024
fa49711
Modify BHoM Enum TextComparisonType
GCRA101 Apr 26, 2024
87e275c
Add LevelComparisonType Enumeration
GCRA101 Apr 26, 2024
4b1fa4f
Add conversion methods for FilterMaterialRule and FilterLevelRule in …
GCRA101 Apr 26, 2024
afd0b49
Update conversion of BHoM ViewFilters to Revit Parameter Filter Elements
GCRA101 Apr 26, 2024
4bbea09
Add enum values to TextComparisonType Enumeration
GCRA101 Apr 26, 2024
5cbef88
Update ToRevit ParameterFilterElement with additional TextComparisonT…
GCRA101 Apr 26, 2024
5c832b1
Add adapter code for FilterRules in ViewFilterFromRevit Method in Fro…
GCRA101 Apr 27, 2024
c329c72
Add FilterElementIdRule to the Revit BHoM Objects
GCRA101 Apr 28, 2024
6685f06
Add handling of FilterElementIdRule in conversion of ViewFilter From …
GCRA101 Apr 28, 2024
764157a
Initialize FilterRule Classes in FromRevit and ToRevit Namespaces
GCRA101 Apr 28, 2024
5338ba9
Delete all FilterRule classes created in the Convert.FromRevit/ToRevi…
GCRA101 Apr 28, 2024
29c3c1b
Reinstate the method filterCategoryRuleToRevit in the Convert.ToRevit…
GCRA101 Apr 28, 2024
41d425e
Add method to convert a Revit ParameterFilterElement into a BHoM View…
GCRA101 Apr 28, 2024
0186d7f
Incorporate minor fixes to references between classes
GCRA101 Apr 28, 2024
e0e27b2
Add ParameterValuePresenceRule
GCRA101 Apr 28, 2024
78306b0
Move all BHoM Filter Rules from oM.Elements to oM.FilterRules namespace.
GCRA101 Aug 19, 2024
4d56096
Refactor the partial class FromRevit.ViewFilter
GCRA101 Aug 19, 2024
0984037
Fix code for conversion of Revit Views into BHoM Views
GCRA101 Aug 19, 2024
69841b2
Make explicit distinction between Revit and BHoM View Class instances
GCRA101 Aug 19, 2024
5fefeed
Add conversion of BHoM FilterRule to Revit FilterRule
GCRA101 Aug 20, 2024
0c033a8
Fix bug with extraction of revit Id of selected parameter
GCRA101 Aug 20, 2024
23f5cae
Fix code for conversion of filterRules from BHoM to Revit_Core_Engine…
GCRA101 Aug 21, 2024
d60bfe5
Add call to method for convertion of FilterLevelRule to Revit.
GCRA101 Aug 21, 2024
bedbda8
Fix bug in creation of Revit Element Filter from BHoM FilterRules
GCRA101 Aug 21, 2024
a87ea3f
Add changes to Level and Material FilterRule Conversion
GCRA101 Aug 21, 2024
86d35dd
Fix bug with Push of View Filters based on Levels
GCRA101 Aug 21, 2024
1580cd6
Fix bug dispatching different types of FilterRule
GCRA101 Aug 27, 2024
07ab5b5
Turn FilterNumericValueRule into an abstract class
GCRA101 Aug 27, 2024
1fb229a
Fix bug related to incorrect extraction of Categories from the model.
GCRA101 Aug 27, 2024
06532f6
Add feature to create ViewFilters with No Rules.
GCRA101 Aug 27, 2024
55f414c
Fix code for extraction of categories and filter rules from Revit whe…
GCRA101 Aug 28, 2024
13a9772
Add GetParameterById Utility function and minor updates to parameter …
GCRA101 Aug 28, 2024
f6cdfc0
Add use of utility function GetParameterById where required to get pa…
GCRA101 Aug 28, 2024
fc1f664
Add conversion of double internal units when pulling filter parameter…
GCRA101 Aug 28, 2024
8ad2801
Add Update Method for Autodesk Revit View3D Class
GCRA101 Sep 2, 2024
463807e
Turn Update Methods for View and View3D into a single method using Ge…
GCRA101 Sep 2, 2024
42cd96d
Fix Fill and Line Pattern Name search turning letter case to Upper
GCRA101 Sep 2, 2024
9d17a6e
Fix bug text comparison between Cut and Surface Patterns
GCRA101 Sep 2, 2024
f7f8cdc
event suppression added
pawelbaran Sep 3, 2024
df3249e
Event suppression added to methods parsing properties of SpecTypeId a…
pawelbaran Sep 5, 2024
0edce3f
Update assembly file version to 8.0.0.0 and AssemblyVersion to 8.0.0.0
BHoMBot Sep 20, 2024
5a06ccf
Remove previous version attributes for 8.0
BHoMBot Sep 20, 2024
869f2de
Start of milestone changes for 8.0 (#1506)
adecler Sep 23, 2024
4be195d
Incorporate PR comments from Pawel Baran - Part01
GCRA101 Oct 14, 2024
a2f6205
Add new abstract class FilterParameterRule
GCRA101 Oct 14, 2024
b348415
Incorporate PR comments from Pawel Baran - Part02
GCRA101 Oct 15, 2024
5486724
Incorporate comments from Pawel Baran - Part03
GCRA101 Oct 15, 2024
3338dac
Incorporate PR Comments from Pawel Baran - Part04
GCRA101 Oct 15, 2024
7abafcc
draft oM classes added
pawelbaran Jan 29, 2024
919b232
draft support for pull of views and view filters added
pawelbaran Jan 29, 2024
584b00a
draft support for views and view filters added
pawelbaran Jan 29, 2024
5fe79b2
Add bespoke classes defining graphics settings for new view filters
GCRA101 Feb 19, 2024
35ea7fa
Rename Class FilterWithOverrides to ViewFilterWithOverrides
GCRA101 Feb 19, 2024
042e1b9
Add FilterRuleType Enumeration
GCRA101 Feb 19, 2024
e0d96d6
Move classes FillPattern, FilterRule and LinePattern from Elements to…
GCRA101 Feb 20, 2024
4a7247e
Implement Update of View based on filters and overrides
GCRA101 Feb 20, 2024
4031e85
Add minor updates to main classes in Elements namespace
GCRA101 Feb 20, 2024
970b4f2
Implement Conversion of BHoM classes to Revit
GCRA101 Feb 20, 2024
b4724ed
Add minor updates to BHoM ViewFilterOverrides Class
GCRA101 Feb 20, 2024
3cf7985
Update Query/BHoMType.cs class for View and ParameterFilterElement
GCRA101 Feb 20, 2024
99691d4
Minor updates to main new classes for View and filtering
GCRA101 Mar 12, 2024
cd9f1aa
Add FilterRuleEvaluatorType Enumeration
GCRA101 Apr 20, 2024
214fb7e
Add FilterValueRule and modify FilterRuleType
GCRA101 Apr 20, 2024
a8a6590
Delete FilterRuleType Enum
GCRA101 Apr 25, 2024
620b9c7
Create FilterRule classes mirroring Revit API classes
GCRA101 Apr 26, 2024
045991f
Move FillPattern and LinePattern to the Enums Namespace
GCRA101 Apr 26, 2024
e084976
Modify BHoM Enum TextComparisonType
GCRA101 Apr 26, 2024
45d9b1c
Add LevelComparisonType Enumeration
GCRA101 Apr 26, 2024
ebe8d7b
Add conversion methods for FilterMaterialRule and FilterLevelRule in …
GCRA101 Apr 26, 2024
e851805
Update conversion of BHoM ViewFilters to Revit Parameter Filter Elements
GCRA101 Apr 26, 2024
92f256f
Add enum values to TextComparisonType Enumeration
GCRA101 Apr 26, 2024
b15705b
Update ToRevit ParameterFilterElement with additional TextComparisonT…
GCRA101 Apr 26, 2024
f14e530
Add adapter code for FilterRules in ViewFilterFromRevit Method in Fro…
GCRA101 Apr 27, 2024
167de7a
Add FilterElementIdRule to the Revit BHoM Objects
GCRA101 Apr 28, 2024
49cb7b6
Add handling of FilterElementIdRule in conversion of ViewFilter From …
GCRA101 Apr 28, 2024
d4aa31a
Initialize FilterRule Classes in FromRevit and ToRevit Namespaces
GCRA101 Apr 28, 2024
f65b802
Delete all FilterRule classes created in the Convert.FromRevit/ToRevi…
GCRA101 Apr 28, 2024
0d761a2
Reinstate the method filterCategoryRuleToRevit in the Convert.ToRevit…
GCRA101 Apr 28, 2024
4c9918d
Add method to convert a Revit ParameterFilterElement into a BHoM View…
GCRA101 Apr 28, 2024
223768c
Incorporate minor fixes to references between classes
GCRA101 Apr 28, 2024
0c1c4bf
Add ParameterValuePresenceRule
GCRA101 Apr 28, 2024
76bf7ec
Move all BHoM Filter Rules from oM.Elements to oM.FilterRules namespace.
GCRA101 Aug 19, 2024
aecfb01
Refactor the partial class FromRevit.ViewFilter
GCRA101 Aug 19, 2024
7ca2b5c
Fix code for conversion of Revit Views into BHoM Views
GCRA101 Aug 19, 2024
0ce26f7
Make explicit distinction between Revit and BHoM View Class instances
GCRA101 Aug 19, 2024
8bfe55d
Add conversion of BHoM FilterRule to Revit FilterRule
GCRA101 Aug 20, 2024
7f22f9d
Fix bug with extraction of revit Id of selected parameter
GCRA101 Aug 20, 2024
f99df39
Fix code for conversion of filterRules from BHoM to Revit_Core_Engine…
GCRA101 Aug 21, 2024
65f491b
Add call to method for convertion of FilterLevelRule to Revit.
GCRA101 Aug 21, 2024
a4a98af
Fix bug in creation of Revit Element Filter from BHoM FilterRules
GCRA101 Aug 21, 2024
5aeb945
Add changes to Level and Material FilterRule Conversion
GCRA101 Aug 21, 2024
3fe9b8f
Fix bug with Push of View Filters based on Levels
GCRA101 Aug 21, 2024
ccb18c5
Fix bug dispatching different types of FilterRule
GCRA101 Aug 27, 2024
dcf3b32
Turn FilterNumericValueRule into an abstract class
GCRA101 Aug 27, 2024
1ba1bca
Fix bug related to incorrect extraction of Categories from the model.
GCRA101 Aug 27, 2024
afc9460
Add feature to create ViewFilters with No Rules.
GCRA101 Aug 27, 2024
b172fb2
Fix code for extraction of categories and filter rules from Revit whe…
GCRA101 Aug 28, 2024
71f2d47
Add GetParameterById Utility function and minor updates to parameter …
GCRA101 Aug 28, 2024
bb2b11c
Add use of utility function GetParameterById where required to get pa…
GCRA101 Aug 28, 2024
4e5f8f9
Add conversion of double internal units when pulling filter parameter…
GCRA101 Aug 28, 2024
4796b12
Add Update Method for Autodesk Revit View3D Class
GCRA101 Sep 2, 2024
e236c32
Turn Update Methods for View and View3D into a single method using Ge…
GCRA101 Sep 2, 2024
9853368
Fix Fill and Line Pattern Name search turning letter case to Upper
GCRA101 Sep 2, 2024
bdde33f
Fix bug text comparison between Cut and Surface Patterns
GCRA101 Sep 2, 2024
d56be5b
Incorporate PR comments from Pawel Baran - Part01
GCRA101 Oct 14, 2024
4767a61
Add new abstract class FilterParameterRule
GCRA101 Oct 14, 2024
a6e0960
Incorporate PR comments from Pawel Baran - Part02
GCRA101 Oct 15, 2024
a2377a6
Incorporate comments from Pawel Baran - Part03
GCRA101 Oct 15, 2024
fbdae30
Incorporate PR Comments from Pawel Baran - Part04
GCRA101 Oct 15, 2024
518a274
Incorporate PR comments from Pawel Baran - Part 05
GCRA101 Oct 15, 2024
a521793
Merge modifications
GCRA101 Oct 15, 2024
a75cff0
Fix merge conflict
GCRA101 Oct 15, 2024
53b434e
Fix minor bugs with dynamic casting and conversion between Category E…
GCRA101 Oct 16, 2024
b36aaa2
Update name of method OverrideGraphicSettings#fromRevit based on Pasc…
GCRA101 Oct 16, 2024
94b1712
Remove FilterRule downcasting and use of generic T type in Update Met…
GCRA101 Oct 16, 2024
501e2c2
Replace Try-catch statements with If-then statments for controlling e…
GCRA101 Oct 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add FilterValueRule and modify FilterRuleType
To simplify the mirroring representation of the Revit API classes within the BHoM, it's necessary to add a concrete classe, subclass of FilterRule, that
corresponds to the FilterValueRule from Revit API.
Whatever sub-class type as well as Evaluator class type will be represented in BHoM via enumeration classes assigned to the RevitFilterRule and RevitFilterValueRule
as attributes.
GCRA101 committed Apr 20, 2024
commit 3f2a258bab270ebc047e00ea6c5cd7981b82d386
21 changes: 10 additions & 11 deletions Revit_oM/Views/FilterRuleType.cs
Original file line number Diff line number Diff line change
@@ -8,16 +8,15 @@ namespace BH.oM.Revit.Views
{
public enum FilterRuleType
{
EQUALS,
GREATER,
GREATER_OR_EQUAL,
LESS,
LESS_OR_EQUAL,
CONTAINS,
NOT_CONTAINS,
BEGINSWITH,
NOT_BEGINSWITH,
ENDSWITH,
NOT_ENDSWITH
VALUE_STRINGRULE,
VALUE_NUMERICRULE_DOUBLE,
VALUE_NUMERICRULE_ELEMENTID,
VALUE_NUMERICRULE_INTEGER,
VALUE_GLOBALPARAMASSOCIATION,
INVERSE,
CATEGORY,
PARAMVALUEPRESENCE_NOVALUE,
PARAMVALUEPRESENCE_VALUE,
SHAREDPARAM_APPLICABLE
}
}
12 changes: 12 additions & 0 deletions Revit_oM/Views/FilterValueRule.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace BH.oM.Revit.Views
{
internal class FilterValueRule
{
}
}