Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify intersect methods #1465

Open
michal-pekacki opened this issue Mar 27, 2024 · 1 comment
Open

Unify intersect methods #1465

michal-pekacki opened this issue Mar 27, 2024 · 1 comment
Assignees
Labels
type:compliance Non-conforming to code guidelines type:feature New capability or enhancement

Comments

@michal-pekacki
Copy link
Contributor

Description:

Currently we have overlaping methods for checking intersection between elements stored in three different files:

  • DoesIntersect
  • IsInRange
  • IsContaining

It would be good to merge them and store in one place.

@michal-pekacki michal-pekacki added type:compliance Non-conforming to code guidelines type:feature New capability or enhancement labels Mar 27, 2024
@michal-pekacki michal-pekacki self-assigned this Mar 27, 2024
@pawelbaran
Copy link
Member

@michal-pekacki takeaways from our conversation about improvements of DoesIntersect method:

  • instead of casting 3 rays in global X, Y, Z, cast one ray in direction of solids centroid (if point within tolerance from centroid, then cast in arbitrary direction, global X?)
  • add acceptOnEdge method parameter similar to Geometry_Engine methods, with the following:
            if (acceptOnEdge)
            {
                //iterate over faces and check if dist within tolerance
            }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines type:feature New capability or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants